am i blind or is the 'request review from...' function somehow disabled for the monero github repo?

selsta: 7805 - nothing more to nitpick.

7825 needs somebody to look at the wallet2.cpp changes.

mj-xmr[m]: it's enough to compare the patches in 7825 against the ones merged into master branch

.merge+ 7805

selsta: OK, so I've just done it. Check.

ty

np

.merge+ 7825

Added

.merges

<ndorf> "am i blind or is the 'request..." <- As far as I can see, you can Re-request a review from sb., who has already checked. That symbol on the right of the avatar.

circle with arrows

stopwatch

ruff ruff

this failes: git checkout v0.17.2.0 ; git submodule update

which causes the plain 'make' build to fail

external/miniupnp does not have the commit that master expects

anyone know where 4c700e09526a7d546394e85628c57e9490feefa0 can be found?

wfaressuissia: yep, was already following that, but the repo is missing a commit or something

it fails if I use: git checkout release-v0.17 ; git submodule update

either branch or tag fails after the submodule update

sorry, I'm too dumb to help then

no worries

lru: try these:

git submodule sync

git submodule update --init --recursive

git submodule update --init --force

cmake -S . -B build -DMANUAL_SUBMODULES=1

UkoeHB: thanks, didn't realize --recursive was needed on update

indeed, `--recursive` was that magic flag

maybe that's my first patch... to README.md :-)

"monero-project/monero #7650/files", too late, it's already there

wfaressuissia: it doesn't have the --recursive flag on update

that's what led me astray

repeat again your steps without `--recursive`

well, that's what led me here... I did a plain git clone without recursive, then I saw that if I already had it downloaded, I could just do 'submodule init && submodule update' but I never did --recursive until UkoeHB mentioned it

"paste.debian.net/hidden/7f92ac47", "113 Fetched in submodule path 'external/miniupnp', ..."

lru: `git submodule sync` was the command you need

another person with issue of the gui not closing on windows reddit.com/r/monerosupport/comments/pa7v69/help_pls

Lyza: can you open the GUI twice on Windows?

if yes it's not clear that they have the same issue as you, just that they had multiple GUI instances open

(not that I'm doubting your issue, just that it doesn't seem clear from issue description)