luigi1111w: do you have time for cli and gui merges tonight or tomorrow? would make it easier to check what's left to do

.merges

luigi1111w: could you approve the workflow here? monero-project/monero #7897 ?

done

thnks

selsta: what does it mean to approve the workflow in this context? All the checks are failing there for a good reason.

What's the status of NFTs and monero currently anything in dev ?

selsta: I get it now. It couldn't start before lugi approves.

Just a heads up to all patch (/PR) contributors: the new CI features like more granular caching, won't work until you rebase.

It is kind of a loophole of GitHub I must admit. The person who has an older CI version in a given PR (before rebasing), could be pushing a breaking change, which was detected outside of the person's PR.

hello. What I need do with this error?

> <@bigmenpixel:matrix.org> hello. What I need do with this error?

> bin.snopyta.org/?369d2bf7bf4441d5#6…JLYS1PVeaBWM7F2JaieXgJQxPVcYGDWvuqt

this monero 0.17.2.0

> <@bigmenpixel:matrix.org> hello. What I need do with this error?

> bin.snopyta.org/?369d2bf7bf4441d5#6…JLYS1PVeaBWM7F2JaieXgJQxPVcYGDWvuqt

Hi. It appears that the <algorithm> header is missing in that file. These problems happen across various compilers, since some toolchains include the header implicitly in other headers, wile others don't.

I'd suggest including that header in the file that failed to compile and PR it or pasting a patch that does this.

In other words - the code is wrong, not your setup.

and "that file" is `src/common/i18n.cpp`

Space: also please check if the same problem happens on Master in your setup.

.merge+ 7828

Added

hyc: monero-project/monero 987eb66

do you remember how to reproduce this linking issue? I undid these changes in monero-project/monero #7898 and can't reproduce the linking issue

will try with added readline to CI

selsta: sorry no, don't remember

hard to believe that's 4yrs ago already

you'd need to check a full gitian build; probably the problem shows up on non-linux

we do run gitian on all PRs

seems to compile fine everywhere

wait

we run depends, not gitian

but shouldn't matter

selsta: Thanks for answering. You said "integrated addresses = payment ids, subaddresses just have an index". And while that is true, all TXs have a payment ID correct? Not that it should necessarily be done, but you can provide payment IDs to subaddresses, correct ?

subaddresses don't support payment ids

all transactions have a dummy payment id, yes

I don't see android on those

Is it possible to utilize those payment IDs on those TXs without a fork, just wallet changes? I was just wondering because theres talk on GitHub about deprecating integrated addresses, but I see no other way to solve my issue w/o integrated addresses.

hyc: wallet_rpc links against `${EPEE_READLINE}` but not `${GNU_READLINE_LIBRARY}` so that could be an issue

simplewallet links against both

wallet_rpc has no cli so it shouldn't need gnu readline

I meant ./monero-wallet-rpc binary, not sure if I looked at the correct cmake target

It was added here monero-project/monero c336d0f

whatever. if wallet-rpc binary links without errors then it's of no concern

ok

will test android too then it should be good

jerfo: I don't really understand what you want to do

Well before I explain, I guess it would be safe to say that if integrated addresses were deprecated, that the payment ID field would also be deprecated right?

Integrated addresses are not deprecated. Long unencrypted payment ids are deprecated. Integrated addresses use short encrypted payment ids.

You could write code to add whatever info you like to txes, and code to interpret that info. Consensus won't stop you (though it might in the future).

Sorry I meant hypothetically. I know they aren't deprecated now, I meant to ask that in the future, IF integrated addresses were to bedeprecated, that the payment ID field would also.

integrated addresses are just a different way for writing address + payment id

so yes

Maybe jerfo got nervous because of this proposal to drop intergrated addresses: monero-project/monero #7889

Also discussed on Reddit

<mj-xmr[m]> "Space: also please check if..." <- Ok, thanks, I'll check tomorrow

Are these even used by monero ?

No.