-
Rucknium[m]
marasli: Check Townforge code
-
selsta
.merges
-
xmr-pr
7828
-
selsta
.merge+ 7884 7883 7880 7898 7899 7875 7858 7855 7823
-
xmr-pr
Added
-
mj-xmr[m]
<selsta> "are there any people here that..." <- AFAIK `make`, used by the CI, is the equivalence of `make release-static`. It works by installing libunbound-dev.
-
selsta
make does not run release-static by default
-
mj-xmr[m]
the CI actually makes a "custom" CMake command chain, but it resembles the default `make`. It builds static libs with tests.
-
selsta
I'm quite sure at least
-
mj-xmr[m]
It doesn't call it directly, but the only difference is, that release-static uses a generic architecture.
-
mj-xmr[m]
But I will gladly try out your branch on my machine.
-
mj-xmr[m]
mj-xmr[m]: Release is static by default here. Debug is shared by default.
-
selsta
make runs the `release-all` target by default, which does not set `-D STATIC=ON`. STATIC is false by default, as can be seen here:
github.com/monero-project/monero/blob/master/CMakeLists.txt#L468
-
selsta
You might be talking about `BUILD_SHARED_LIBS`?
-
mj-xmr[m]
selsta: You are right about this one, alright, but I have to look deeper on whether `-D STATIC=ON` actually makes any impact.
-
selsta
it does static linking of external libraries
-
mj-xmr[m]
Yeah, ok I see now.
-
selsta
Currently, static unbound is built automatically due to the submodule. If we remove the submodule it is necessary to build it manually.
-
selsta
it shouldn't be too much of a problem IMO
-
mj-xmr[m]
Anyway, I'm building your branch right now with `release-static`. The lib isn't being built, like it's expected. CMake complained about missing lib, which went through after installing it via apt. So far so good.
-
mj-xmr[m]
OK, selsta , I see the problem. I have a bunch of undefined references under Debian, even though the .deb package installed the static lib as well.
-
mj-xmr[m]
In that case, I'd say, that having a possibility of supplying an externally built libunbound to the system, just like we do with Boost, would be a good follow up task of your PR.
-
selsta
supplying how?
-
selsta
the boost build script?
-
mj-xmr[m]
-DBoost_INCLUDE_DIR="$HOME/devel/lib/boost/1.77.0/include"
-
mj-xmr[m]
This is how I do it.
-
mj-xmr[m]
selsta: An unbound build script wouldn't hurt maybe, yeah.
-
selsta
-D UNBOUND_ROOT might work
-
mj-xmr[m]
Therefore I think your PR isn't a blocker.
-
mj-xmr[m]
at least for Master
-
selsta
IMO we just should recommend to use make depends, and everyone who wants to use `make release-static` has to figure out how to compile static dependencies themselves.
-
selsta
If no one disagrees with this I will add it to merge queue tomorrow.
-
mj-xmr[m]
I see the main Makefile just as an example of things that you can do with CMake. I haven't used the Makefile since almost the beginning. Except for the `depends` calls of course.
-
mj-xmr[m]
And as long as a simple `make` works for the stop-by dev, we should be fine.
-
utxobr[m]
on building - just made
github.com/cirocosta/monero-builds public, might be useful for folks w/ many cpus
-
utxobr[m]
many cores*
-
utxobr[m]
leverages buildkit so we can get some sweet concurrent builds of each dependency, as well as a cache mount for ccache
-
hyc
yeah, I think we can assume the casual builder just running default "make" only cares about building a binary for their own machine
-
hyc
so static is unnecessary then
-
marasli
hello
-
selsta
>No fork help, you’re on your own
-
marasli
free choice of helping or not
-
marasli
is like jab u must have the choice yes or no
-
marasli
no choice is not good thing
-
UkoeHB
marasli: ask in #monero, that topic is not good for this channel.
-
marasli
on #monero u must log
-
marasli
i'm pro on everything free
-
marasli
if someone do bad things u just block
-
marasli
is better this than putting people to give their time for signing etc