libera #monero-dev

27 Sep 2021

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Monero GUI dev is at #monero-gui || Monero website dev is at #monero-site || Non-dev questions -> #monero, please || No fork help, you’re on your own

• 11:09
  mj-xmr[m]
  <rbrunner> "What would be a good C++ / STL..." <- deque
• 11:10
  mj-xmr[m]
  unless the input is meant to be inserted into random locations, but still sorted.
• 11:11
  moneromooo
  Mining nodes will erase and insert at arbitrary positions.
• 11:12
  mj-xmr[m]
  Then you're right about the map/
• 11:12
  moneromooo
  In fact, also non mining nodes, though less so.
• 11:57
  mj-xmr[m]
  rbrunner: a map also allows access to its first (sorted) element via .first() (provided it's not empty()) and later via begin() + i
• 11:58
  mj-xmr[m]
  It's just that its deletions will be a bit slow, but I doubt that these operations will be done so often, that it would matter.
• 12:57
  tauntaum
  hello
• 12:57
  tauntaum
  this monero-project/monero #7803 monero-project/monero #7891 has small conflicts
• 12:58
  tauntaum
  and both are very important
• 13:41
  mj-xmr[m]
  #7803 is vtnerd 's. I'm planning to review this on the weekend, or in the next week.
• 14:29
  jerfo
  Do y'all have any clue what's causing monero-project/monero #7970?
• 14:32
  selsta
  Somehow one of the includes changes the default log level.
• 14:33
  selsta
  but I didn't go through the code in detail
• 14:35
  mj-xmr[m]
  I put this on my next week's todo list.
• 14:35
  mj-xmr[m]
  selsta: 7912 would be very useful before the next release.
• 14:40
  moneromooo
  Possibly something setting MONERO_DEFAULT_LOG_CATEGORY in a header.
• 14:49
  selsta
  mj-xmr[m]: left a comment
• 14:50
  mj-xmr[m]
  Thanks. Needs a deeper look then.
• 14:51
  selsta
  shouldn't be much work to change
• 15:35
  hyc
  sadly, not as easy as it seemed
• 15:43
  selsta
  hyc: it does not use gbuild as far as I can see
• 15:44
  selsta
  but if it's too much work / not easy I can merge as is
• 16:00
  hyc
  I'm still tinkering with it
• 16:05
  hyc
  if it's not using gbuild or any of that setup, particularly GBUILD_PACKAGE_CACHE or GBUILD_COMMON_CACHE then I'll just switch on one of those vars instead
• 16:22
  selsta
  hyc: hmm I did find GBUILD_CACHE_ENABLED=1 now in the Dockerfile, whatever, let's still merge it
• 16:22
  selsta
  that can be solved later
• 16:22
  selsta
  .merge+ 7912
• 16:22
  xmr-pr
  Added
• 16:23
  hyc
  ok
• 16:25
  hyc
  do we need release-0.17 versions of these, or is this for v0.18?
• 16:27
  selsta
  both would be fine
• 16:28
  hyc
  ok I'll do 0.17 in a little while
• 19:55
  hyc
  hmmm, what's the CI build doing differently from gitian and/or depends? github.com/monero-project/monero/ru…s/3723220908?check_suite_focus=true
• 19:55
  selsta
  hyc: brew installed openssl3 which doesn't get recognized somehow
• 19:55
  selsta
  looking into it currently
• 19:55
  hyc
  ok
• 19:56
  hyc
  openssl3 deprecates a lot more functions, there's prob a fair bit of compat work needed
• 19:56
  selsta
  might be easier to change CI to openssl1.1
• 19:56
  selsta
  for now
• 19:56
  hyc
  yeah that'd certainly take care of it for now
• 20:06
  razor[m]
  ¯_(ツ)_/¯
• 20:07
  razor[m]
  ¯_(ツ)_/¯\
• 21:25
  selsta
  hyc: monero compiles fine with openssl3, just some deprecation warnings as you said
• 21:25
  selsta
  now I just have to find out why it fails on CI