simplewallet depends on wallet2

so you can't just take simplewallet out

i notice others have used "libwalletqt" from the GUI wallet, but that obviously depends on Qt

not much of a cpp talent, but I'd like to help with testing if needed, I've the read

is there anything on the "to do" list I could assist with ?

I can imagine that starting to reply to the enormous pile of open, unanswered issues would be greatly appreciated :)

Rucknium[m]: you can use wallet_api

src/wallet/api/ ...

ga_1700[m]: in general open PRs always benefit from testing

ga_1700[m]: monero-project/monero #8046 for example should speedup tx generation, that is something you could test

Rucknium[m]: sorry, didn't mean to ping you, the other person has left

<selsta> "ga_1700: in general open PRs..." <- I think I saw a "how to" about testing, looking for it now.

vtnerd: mooo addresses your comments, can you recheck? monero-project/monero #7170

alright, each PR seems to have github actions running jobs and some tests, where does the human element for testing come in, or does it come into play at all ?

* actions running CI jobs and

s/alright, each PR seems to have github actions running jobs and some tests, where does the human element for testing come in, or does it come into play at all ?/alright, each PR seems to have github actions running CI jobs and some tests, where does the human element for testing come into the workflow, or does it come into play at all ?/

it depends on the changes

It seems like labels are not being used much, so there wouldn't be much of a way for a nube to know which PR requires attended testing ?

yes, labels would help

alright, seems like the build process is fairly straight forward and you have things documented, however without labels and/or internal knowledge of "which PR requires which action", not much can be done, I'm afraid (also, github actions take care of quite a bit, as it should).

* I'm afraid. (also,

selsta: ok

mdb readers crashed my node

is it the node that you use for xmrchain?

no, the one im running with p2pool daemon

and i already had the mdb_stat thing set to run every 3 mins in cron

weird

i got monerod spiking to 1600% cpu. ive never seen it use that many threds

maybe i just don't pay attention that often

which node now? the same with the reader issue?

yeah

its running the modded daemon for p2pool.

1600% cpu isn't normal

doesn't p2pool use zmq and not the blockchain directly?

yeah. its settled down to the normal 130% zone

i was getting tons of these when it was blastin: 2021-11-15 04:00:37.215 [P2P1] INFO perf.ringct src/common/perf_timer.cpp:156 PERF 4666 verRctCLSAGSimple

github.com/monero-ecosystem/monero-…developer_guide/creating_wallets.md can someone explain what the difference between monerojs.createWalletFull and monerojs.createWalletKeys is? what is a keys only wallet? How do I go about opening a wallet from a only a viewkey? is it related to "keys only wallet" or does it have nothing to do with it and i could use both functions?

woodser[m]: ^

the keys-only wallet only does basic key management, like restoring from seed and getting keys and addresses, whereas the full wallet can connect to a node, scan for transactions, and maintain wallet state. you'd want to create a full wallet in order to scan a view-only wallet, like this from this example: github.com/monero-ecosystem/monero-…eveloper_guide/view_only_offline.md

<woodser[m]> "the keys-only wallet only does..." <- thanks a lot. I was going through the javascript files and saw that full implemented functionality on top of keys. But I wasnt really sure what the intended usecase for both of these respective APIs was. Thanks for clearing that up. Maybe I can make a short video on how to combine this with express.js and make something useful. 😀

sure. the motivation was to offer a smaller file for basic key management, 1.18 mbs vs 5.24 mbs for the full wallet

woodser[m]: can you name a usecase where you would use keys over full? just so I would be able to mention something and explain the tradeoff.

like for a mnemonic generator, address validator, or deriving deposit addresses from a view-only wallet

woodser[m]: just to be sure: I want to ask the end users for proofing their transactions and then verify these proofs in the express.js backend. I recon interacting with the wallet is thread safe, right? so I can startup the wallet together with the server in app.js and make it available as a global variable. And then access it from the requests. There wouldnt be any interference between the different requests, right? similar like

sending multiple calls over RPC and waiting for their responses.

> I recon interacting with the wallet is thread safe, right?

yes, it should be

> <@woodser:haveno.network> > I recon interacting with the wallet is thread safe, right?

>

> yes, it should be

amazing! thank you so much for your work! I cant wait to play around with this and work on a solution that doesnt require the separate deployment of a walletrpc

great, hope you have success, please keep me posted :)

View tags PR :) monero-project/monero #8061

view tags are super exciting - thanks jberman!

<john_r366> "view tags are super exciting..." <- Yes! But what's not super-exiting is that the IRC-->Matrix bridge is still sleepy.

exciting*

While working on `wallet2.cpp`I stumbled over the following comment:

I guess the time of that "TODO" has come.

But what makes me suspicious: That will bring the timeout until tx failure down from 500 seconds to 60 seconds. Is that right?

git tells me that selsta wrote that about 1 year ago. Hmmm, maybe still not yet time then? What is the "v15" hardfork, again?

see monero-project/monero #7058

500 seconds was the current max timeout due to people running old code

I see, thanks

"That will bring the timeout until tx failure down from 500 seconds to 60 seconds. Is that right?" <-- correct, the extra seconds currently are due to a bug in monero-project/monero #7021

I don't remember where the second 120s come from but there was a reason for it

should have documented it better :)

Ah, now I understand. First somebody thought we could already now use the new lower value, and you found out, no, not yet, and made that PR.

I was taking a closer look at Monero's URI scheme differs from Bitcoin's BIP21, and there are some differences. Is there a good reason for this?

for example, Monero uses `tx_amount` whereas Bitcoin uses `amount`

looks like Monero uses `recipient_name` and Bitcoin uses `label`

Monero uses `tx_description` and Bitcoin uses `message`

Maybe not all these fields are completely 1:1

I opened 8063 and 8064 for various URI things

2

Does anybody here know what the data member named rpc in the RPCTracker class from src/rpc/core_rpc_server.cpp is for?

Or how the paying_for parameter to rpc_access_pay works?

the `rpc` member tracks the name of the function being tracked for performance

Thank you very much

I think the `paying_for` parameter is just a used as a notice that shows in the log

but I've not interacted with that particular feature of the daemon much