-
chesterfield[m]
Whipping up a little thing with the monero-javascript lib in case anyone wants to check it out:
sunny-malabi-a3b5ff.netlify.app
-
willshu[m]
<moneromooo> "In that case, you could maybe..." <- I have been looking at the wrong api. If I query with `get_block`. I actually get the amount:... (full message at
libera.ems.host/_matrix/media/r0/do…8466fbd8dad21d7b0f6fa7cfe39f4075050)
-
willshu[m]
So I only have one problem, how do I calculate if the vout belongs to my wallet with `target.key` and my privateViewKey?
-
willshu[m]
Well, here the vout belongs to `miner_tx`, so I guess the list of vout is actually coinbase transactions, not the transactions mined by the miner, am I correct?
-
selsta
.merge+ 8227 8228
-
xmr-pr
Added
-
selsta
.merge+ 8179
-
willshu[m]
-
willshu[m]
Hello, this is the `unsigned_txset`, how do I decode it to get from, to, amount etc?
-
selsta
-
selsta
.merge+ 7153
-
xmr-pr
Added
-
willshu[m]
<selsta> "will.shu: isn't it part of the..." <- It's part of our internal risk audit before we broadcast we need to check if the info is correct, so we need to decode it.
-
selsta
-
selsta
e.g. port it to python or so
-
selsta
but doesn't the output of `sign_transfer` show what you need to know anyway?
-
luigi1111w
.merges
-
xmr-pr
7153 7170 7936 7937 8053 8166 8177 8179 8180 8195 8196 8197 8205 8207 8211 8212 8213 8215 8222 8223 8227 8228
-
selsta
.merge+ 7937
-
selsta
sorry, had to add this too :D
-
selsta
ugh it was already, forget it
-
luigi1111w
^_^
-
luigi1111w
.merge- 7936
-
xmr-pr
Removed
-
selsta
.merges
-
xmr-pr
8207 8211
-
selsta
bulletproofs+ is now merged
-
vtnerd
-selsta my fault for holding up the bp+ review as well, I couldn't review it for various reasons. I will scan over it again over the coming weeks but I already did the hardest reviews a while back
-
vtnerd
the holdup was me verifying parts of the math :/ it looked legit but that is some of the most dense code I've had to review
-
hyc
thanks for doing all that vtnerd
-
hyc
too bad it wasn't written in rust, then it would be intrinsically safe /s
-
vtnerd
hyc: haha sounds like we'll have much to talk about in Miami, as usual
-
vtnerd
Im traveling late today, but Im flying in a "Im thankful for today" tshirt underneath my long-sleeve pullover. Can't wait to break it out at the airport or where ever
-
r4v3r23[m]
so will #8046 be added to the HF? looks like sech1 is on it
-
r4v3r23[m]
-
r4v3r23[m]
<selsta> "we still need someone to..." <- so will this be added to the HF? looks like sech1 is on it
-
r4v3r23[m]
50% reduction of tx creation time on mobile would be killer
-
selsta
.merge+ 8242
-
xmr-pr
Added
-
selsta
luigi1111w: can you merge ^ soon to fix tests? and GUI too pls
-
monerobull[m]
<r4v3r23[m]> "50% reduction of tx creation..." <- does this have an effect on hardware wallets?
-
monerobull[m]
sitting around waiting for the ledger to construct a transaction, only for it taking so long the device locks itself and you have to start over isnt that fun
-
r4v3r23[m]
<monerobull[m]> "does this have an effect on..." <- moneromoo should be the one to ask
-
r4v3r23[m]
either way looks like a clear winner for UX
-
reeemuru[m]
thx for the merges selsta and luigi1111w 🕺
-
sech1
#8046 doesn't speedup hardware wallets, this is the code that runs on the host PC
-
selsta
sech1: should I add 8046 to the merge list or does a second review make sense?
-
selsta
it's tx generation related so i'm trying to be careful
-
sech1
I went through each commit. I'm not very familiar with that code, but the changes make sense. I think unit tests should catch any bugs?
-
sech1
but yes, a second review would be nice
-
selsta
yes in theory the tests should catch a bug with tx generation, i also tested the PR and it worked fine
-
r4v3r23[m]
<sech1> "#8046 doesn't speedup hardware..." <- unless your phone/pc is your hardware wallet :)
-
sech1
yes, CLI and GUI wallets and everything that uses wallet2 (Cake, Monerujo etc) will get faster
-
hyc
c0-