.merges

Will the merge queue get into 0.18.1 ?

18.1 is done and dusted and the merge queue is for master branch

So 8427 didn't make it. the zmq-pub thingy.

Or was that 8cc3c9af4dde7a32d675c4297d673dee4a9c2514 Publish submitted txs via zmq

Yep, 8451 was the equivalent PR for the release branch and made it in (8427 is for the master branch)

Got it. Thanks.

Hello

I use the view-only wallet plus offline wallet mechanism to sign keyImages and I found a bug.

In the screenshot above is how I sign keyImages in the offline wallet.

I deposited two amounts to the wallet: one at the primary address, one at the subaddress with index 181162. If I set up the view-only wallet to scan just 1000 subaddresses, thus skipping the one at index 181162, the outputhex contains only 1 utxo, it can be imported into the offline wallet and key images be exported without error. But if I set up the view-only wallet to scan 1 million subaddresses, thus including the one at index 181162,

the outputhex will be much longer, and it cannot be properly imported into the offline wallet and key images cannot be exported.

when instantiating `createWalletFull`, can I specify the subaddress to be included?

jeffro256[m]: I'm currently going through unused dependencies, to we use graphviz anywhere? I only see it here: github.com/monero-project/monero/blob/master/CMakeLists.txt#L1230

do*

I think Doxygen uses graphviz for the dependency graph documention

yep, but we don't need it for depends since we don't even build doxygen

Yeah that's, it would only really be needed if you were building Doxygen anyways

I think doxygen uses graphviz for generating images (of, e.g., dependency graphs) during generating documentation, and not for building doxygen.

But maybe that's what you meant by "building doxygen", i.e., running doxygen to build docs.

Yes, if you never run (build) your doxygen documentation, then graphviz never gets uses

yes but still irrelevant for our depends builds

ah okay

I've never even run doxygen on our source tree. does it produce anything interesting?

It steals the main page from lmdb lol

lol

It's basically unusable rn. I have a PR #8333 to reduce a lot of the noise

It documents all the python scripts and it trips over trying to assign all the variables and functions to namespaces so it's really messy. It also documents everything in external/

prob should prune all of external/ from its coverage

v0.18.1.0 binaries are now available at getmonero.org

jeffro256[m]: is 8333 merge ready / approved?

It's merge ready and mj approved it, it's only 4 lines of modifications if you want to review ;)

Instead of logging every single file in the project root directory, it only documents the stuff specific to this project (i.e. epee, the src folder, and easylogging++)

.merge+ 8333

Added

yea looks good

sweet

moneromoooo what do you think of this? monero-project/monero #8489#issuecomment-1212274517

Ideally should the `index=` placement thing be an error or should it just understand either way?