-
jeffro256[m]rbrunner jberman Sorry for arriving so late to the party... I just started reviewing monero-project/monero #8076 since I saw that jberman recently merged his changes into that PR
-
jeffro256[m]I was wondering: why are timestamps used to order the transactions? This seems like it would open up a lot of side channel attack opportunities for bad actors to map out the peer relationships
-
jeffro256[m]Why not something like moneromooo suggested: order incoming txs by an increasing counter
-
jeffro256[m]Still not foolproof against those types of attacks, but most nodes will have the same order
-
jeffro256[m]You could even do some fudging by randomly ordering transactions if multiple transactions show up in between RPC calls to /get_blocks_fast
-
jeffro256[m]Also, then for optimization, we could use an unordered_map instead of a multimap for m_removed_txs_by_time because each transaction entering the pool would have a unique counter ID
-
ofrnxmr[m]What died trusted daemon do about this
-
ofrnxmr[m]Does*. There is a huge difference in data transfer when using trusted daemon (sync starts very fast with sub 100kb download vs 5+ seconds and 3-10mb download)
-
rbrunnerjeffro256[m]: "why are timestamps used to order the transactions?" Not sure what you mean. If you want to have an incremental system, you have to order somehow.
-
rbrunnerAnd now nothing different than before happens: Before, the were also ordered by time, by receiving time. Don't think anything is worse now.
-
rbrunnerBy the way, if you go back to the start of this history, you will find a *log* of ideas how to implement, and a log of arguing back and forth
-
rbrunnerIt seemed everybody from the dev community wanted to chime in with their own idea :)
-
rbrunnerAnd well, now, after more than a freaking year, and again a lot of testing by at least 3 people, and benchmarking, and load testing
-
rbrunnerand what not, it seems it's finally ready to get merged. Thankfully.
-
rbrunnerBut of course everything changes if you find a credible angle of attack, or a concrete exploit
-
rbrunnerEr, I meant you will find a *lot* of ideas of course, not a log ...
-
ofrnxmr[m]Log fits too
-
rbrunnerYeah, but with "log" the statements lack somehow the "impact" that I intended :)