-
jeffro256[m]
> jeffro256: "why are timestamps used to order the transactions?" Not sure what you mean. If you want to have an incremental system, you have to order somehow.
-
jeffro256[m]
Plain old integers allow strict ordering
-
jeffro256[m]
I'll put my money where my mouth is though and write up some code for what I mean
-
jeffro256[m]
It really shouldn't be a huge change to the PR
-
jeffro256[m]
If people decide that its worth pursuing
-
jeffro256[m]
> But of course everything changes if you find a credible angle of attack, or a concrete exploit
-
jeffro256[m]
It wouldn't be a "concrete" exploit in the sense that there's anything deterministic, but third parties would be able to build information on which nodes connect to whom
-
hyc
plain old integers have more race conditions between distributed nodes
-
hyc
timestamps are just integers anyway
-
jeffro256[m]
Well the integer order for refrshing doesn't have to be the same between nodes, it just needs to be consistent for one node
-
jeffro256[m]
(As long as the wallet isn't refreshing from multiple nodes)
-
jeffro256[m]
Idk why it would do that
-
jeffro256[m]
And yeah, timestamps are just integers, but they give more timing information about the network and your node's place in it, as opposed to an increasing integer
-
jeffro256[m]
> Well the integer order for refrshing doesn't have to be the same between nodes, it just needs to be consistent for one node
-
jeffro256[m]
Technically, it just needs to be monotonically increasing for a connection pair (node, wallet) but that's way too much work to implement for not that much gain
-
rbrunner
jeffro256[m]
-
rbrunner
: I am still a bit sceptical whether it's a good idea to investigate in the particular frame of this PR
-
rbrunner
Wouldn't you say that any possibility to find out is already there *before* this PR?
-
rbrunner
I mean some adversary could sample the pool in 5 second intervalls, compare what comes back and derive info from it
-
rbrunner
So could be this is a weakness alright, but it was always there, for many years
-
rbrunner
If that's really the case, I propose to declare this "out of scope" for *this* PR: This is not the PR to remedy year-old weaknesses
-
rbrunner
I would be content to just not make matters worse
-
rbrunner
If you see a weakness, and you want to try to get it out of the way, I propose you wait until this one is merged,
-
rbrunner
and then make a new PR of your own to improve
-
rbrunner
Even if the chances you want to finally contribute, this would make the history of this PR even more complicated than it already is
-
rbrunner
and of course we would have to repeat quite a number of tests, to see whether we don't have any regression
-
rbrunner
Please have mercy, as I said, this PR is already over a year old ...
-
rbrunner
*Even if the changes you finally want to contribute are small ...
-
one-horse-wagon[
Seraphis meeting today at 18:00 UTC in the Matrix room--No Wallet Left Behind. Everyone is cordially invited.
-
Rucknium[m]
rbrunner: I thought similar thoughts when I wrote code to collect txpool data. When restricted_rpc=true, the RPC response doesn't share the time that a tx arrived (receive_time has only one-second time resolution anyway), but you can get a very good approximation by just sending RPC queries frequently.