-
rbrunnerHereby I officially apply to add my PR #8046 to the merge queue, to have it merged into master with the next merge round
-
rbrunnerIt's tested, it's reviewed, it's ready, IMHO. See also monero-project/monero #8076#issuecomment-1459635389
-
rbrunner@selsta, please have a look.
-
rbrunnerAh, PR number is wrong, it's not 8046 of course, it's 8076: monero-project/monero #8076.
-
selstaplease approve again jberman[m]
-
jberman[m]done :)
-
» crowstick[m] uploaded an image: (140KiB) <libera.ems.host/_matrix/media/v3/do…ot%202023-03-08%20at%2014.28.11.png>
-
crowstick[m]I have not opened my GUI for a while but I am going back now to add some XMR and I get the following problem which I never had before. Can anyone help?
-
moneromoooAre you modifying the code or trying to ? If not and you're trying to use monero as is and it doesn't work, try asking in #monero.
-
moneromoooAlso, I suspect you might have posted an image. A link does not show up on IRC.
-
crowstick[m]Many thanks
-
plowsof11No images matrix side
-
plowsof11Oops, this is -dev
-
vtnerdjeffro256[m]: this is an old callback - resolve.cpp looks up both IPv4 and IPv6
-
vtnerdthe code in common is more "basic" it just does one task at a time
-
vtnerdso if you just want an IP 4 or 6, you have to manually do it anyway
-
vtnerdyou can put the code in /common with the other stuff, but since I created a /net folder long ago I decided to just start moving it into there
-
vtnerdI mean you can chop the code, but then you end up re-writing get me v4 and then v6 code. and you can put in /common, but it makes more sense to be in /net and it simply has to call just a few functions in that DNSResolver class
-
selsta.merge+ 8076
-
xmr-prAdded
-
rbrunnerWow, thanks.
-
selstaonly to master for now, I think plowsof11 wanted to do a bit more testing
-
jeffro256[m]I'm cool with adding #8706 to master under the condition that the changes don't make it to the release branch without another PR adding code to invalidate the wallet refresh cache when switching daemons, which shouldn't be a big change at all
-
jeffro256[m]Again, great work rbrunner and jberman
-
jeffro256[m]Sorry for being so picky
-
rbrunnerNo problem, I am cool with that, I have no doubt that further progress is possible or even necessary before release, I just did not see my PR as the good vehicle for that