Hi guys, thought I'd introduce myself, my name is Alex I'm a C++ developper "by trade", started in the aerospace industry and now I program trading systems at a financial institution. I've never worked on an open source project before so this is my first, although I've been into Monero for a while now; I only recently decided to try and contribute on a dare from a friend! I'm making my first commits for issue 8753 please bear

e if I'm a bit clumsy with the PRs, this is quite different from the workflow I'm used to but I'll try to find my bearings quickly.

hi

"Handle case where a command line flag is not allowed in the config file" should still be a good thing to add in addition to the 8753 fix

yeah it's coming with it that was my intention

thats what I meant by clumsy with the PRs lol

ok I approved it :)

I'll push another commit over it though haha (to allow non-interactive in the config file) I was looking for a lock functionality to communicate that it's not ready for approval yet but couldnt find it

hmm, does it touch the exact same code? otherwise I would have thought it would be best to open a separate PR for it

it doesn't so not a problem I can very well make a different PR for it, thanks for the directions

would recommend a separate PR in this case, also there's a draft setting which is what you are looking for when you want to mark something as not ready for approval

or you can add [DO NOT MERGE] into the title

makes sense thanks! I'll ask here next time

congrats on the new release umm, a little late to be asking IG but I'm curious about #8675, seems like there was some disagreement about it

Lyza: there's a follow up pr for it

#8707 ? I guess that's partly why I was asking, looks unfinished

What is speaker's dinner supposed to mean?

sorry wrong chat

:)

It's finished and ready for review

What did you like to know about it?

that's pretty much it. looks like it would be in the next point release then?

Depends on what the reviewers think about it and whether they review it soon

hmm, okay. kind of seems like an optimization patch could have waited but, oh well. I might just hold on updating

Yes I also think sech1 ‘s PR should not have been in the latest release without the fragility fix

Even though it is really fast

fragility to code changes doesn't matter if it's a fixed code release, plus it's already fixed in your PR

yeah as long as that get gets included promptly I think it's not like, the worst thing. I may build my own with that PR once it's ready for merge, will see

rbrunner plowsof Do you have those files that jberman gave you to benchmark the RPC PR?

Me, no.

Didn't come around to re-do the benchmarks

I did some very bare-bones functional tests and didn't see a difference in speed

With a local daemon though, the differences will be more pronounced for a remote daemon

rbrunner I have a peculiar issue while refreshing my CLI wallet (not related to your PR). The refreshing sometimes runs for about one second then stops for no reason because of a connection issue

Do you experience this as well?

If not, I'll start debugging it

jeffro256: will dm the files

Thanks!

I also noticed a similar connection issue recently when I upgraded to ubuntu 22.04. I only see the issue with a compiled daemon, not release binaries. Been looking into the cause, no luck yet

jeffro256[m]: Didn't especially notice something like that.

I sometimes wonder why and how the wallet can go into "not synced" all on its own after some time for me but that's probably yet another story :)

> I also noticed a similar connection issue recently when I upgraded to ubuntu 22.04. I only see the issue with a compiled daemon, not release binaries. Been looking into the cause, no luck yet

Yup! I'm also on Ubuntu 22

jberman[m]: reminds me of monero-project/monero #8731

same

it's what made me think to check the release binaries