-
selstaluigi1111w: I feel like we will have to wait until you are back so that we can have more time to review and test
-
jeffro256[m]@sech1 Okay I trimmed down my alternative PR to its absolute smallest (not including comments), and I made you co-author . I don't want to start a pissing contest over trivial things, but I prefer my PR because it also fixes connection dropping for fees that are too low
-
jeffro256[m]What do you think of it?
-
jeffro256[m]It doesn't make changes to for ZMQ optimization but IMHO that should be a different PR
-
jeffro256[m]> it also fixes connection dropping for fees that are too low
-
jeffro256[m]And could be easily extended to other relay only rules by adding one line of code in the tx pool, without having to touch the protocol handler each time a change is made
-
luigi1111wselsta kk
-
sech1jeffro256[m] do ZMQ fix a second commit too, wtf
-
sech1why are you making everyone do more work
-
sech1I'm working on a totally different fix now, do waste my time
-
sech1*don't waste my time
-
jeffro256[m]sech1: b/c it's a better fix
-
sech1just do a second commit with ZMQ
-
sech1I'm not going to make a separate PR just because "it's more right"
-
sech1I'm working on a different fix already while you're obsessed with "by the book"
-
jeffro256[m]Did you miss the part where my PR in question fixed more than tx_extra?
-
jeffro256[m]It's just 4 lines of code
-
sech1Just look what bug I found: p2pool.io/u/d70f28419ee2a43d/image.png
-
sech1I don't care about that PR anymore
-
sech18808 is ok as long as you add ZMQ fix
-
sech1Soon I'll find out how many threads it's allowed to create per process in Windows, lol :D
-
sech1
-
sech1.merges
-
xmr-pr8794 8805
-
sech18811, 8813 (and their copies for master branch) need a review
-
sech1I mean one more reviewer
-
selsta.merge+ 8810 8811 8808 8813
-
xmr-prAdded