good night

Good morning guys, after further testing I can confirm that when compiling the Monero source code the release version of the build provides the tests however the debug version of the build does not, can I make changes to the tests README.md so this makes more sense?

I compiled the source code with the following commands

make and make debug

Looks like a bug then, neither should build the tests.

Were these in clean trees ? If not, cmake will cache stuff.

cmake can be annoying in what it caches.

Hey moneromooo

What do you mean clean trees? Thanks

I've followed the compile from source instructions the only difference I've done is create my own branch for changes.

How do you clean the cache for cmake?

I mean without a build tree ,which is where cmake caches its stuff.

make clean would clean a tree. Or rm -fr build.

I just looked at the Makefile, this is expected.

The default is to build everything.

I've cleaned the build tree and the bug is reproduced.

option(BUILD_TESTS "Build tests." OFF) should this be changed to ON?

If you can make a good argument that it should be.

If the default is arbitrary, it should be left as is, to avoid confusing people and/or needing to change stuff that already works.

Also, if you problem is simply that you want to build tests wihtout debug flags, you can use make release-test.

Or make release.

I think. Lemme check acrually...

Yes. release-test (though it will try to run the tests, you'll need to ^C if you don't want that).

Can I update the README.md within the tests folder so it reflects what you've just said? At the moment it does not reflect that and is confusing.

Sure.

Thx for the help :)

hello ....

for experiments i suppose its easier to make requeststo daemon, too...

but i encounter q question: pastebin.com/5mnuBsG6 is the miner_tx_hash the same as merkle root ?

No, it's the hash of miner transaction. Merkle root is the root hash of all transactions in the block (arranged in a tree)

ah ok, could i use the merkle root function of bitcoin, for calculating the hash or is it different from monero

?

do i need to hash the result of transaction tree with cryptonote or is the data ready to use after creating merkle root ?

No you can't use bitcoin code for Monero

check src/crypto/tree-hash.c

you need "tree_hash" function

cn_fast_hash = keccak

ok sech1, thank you

:)

vtnerds ccs proposal is up (pending rendered markdown from the description) repo.getmonero.org/monero-project/c…roposals/-/merge_requests/391/diffs