-
plowsof
9574 is said to reduce wallet-rpc bandwidth usage under certain conditions (open / closing a wallet). ofrnxmr mentioned here
libera.monerologs.net/monero-community/20241123#c463404 , is there anything special regarding timing / number of calls to observe this? open a wallet - then send a close wallet call directly after before its finished?
-
plowsof
or just use wallet rpc "normally" to open / close 1?several? wallets?
-
m-relay
<rbrunner7:monero.social> I understand this as such: Programs closed wallets and assumed that the close call does its job correctly and does not only close, but also save the state of the wallet. In some circumstances, it did *not* save because of a bug. The next open call had to sync all over again because of this erronous not-saving. Now the bug is corrected, close does always save, and an open immediate<clipped message>
-
m-relay
<rbrunner7:monero.social> ly after a close has almost nothing to do, like it should be.
-
m-relay
<rbrunner7:monero.social> I dimmly remember that years ago I had cases where mysteriously an "RPC driven" wallet did not save, but I could never reproduce to debug. So now it's finally clear why :)
-
m-relay
<0xfffc:monero.social> Correct.
-
ofrnxmr
In ALL circumstances it didnt save (rbrunner)
-
ofrnxmr
Open > open (without close), dis properly save
-
ofrnxmr
If you close > open, it did not. Otherwise, correct, rbrunner
-
ofrnxmr
s/dis/did
-
ofrnxmr
To reproduce, open_wallet Y. Wait a 1 min, close_wallet > open_wallet Y. repeat. After a day or 2, wallet starts using gbs of data per hr
-
rbrunner
Right. I missed the chance to find the bug already years ago. Found a comment in my monerotech source:
-
rbrunner
"For quite mysterious reasons the 'CloseWallet' call at least on Windows does not save the wallet, as it should, but just "throws it away"
-
ofrnxmr
Use the same wallet on each open
-
ofrnxmr
Yes, and windows requires closing if you issue "open_wallet" on the same wallet (windows locks the file)
-
rbrunner
It's a bit disheartening that such bugs manage to stay for years ...
-
ofrnxmr
its ok. Its monero
-
ofrnxmr
The original fix bt 0xfffc removes a line that was introduced with bytecoin
-
ofrnxmr
monero-project/monero #9592 stuff like this is also disheartening.
-
ofrnxmr
-
ofrnxmr
Who knew "block" or "block time" could have so many definitions? 🙃
-
ofrnxmr
--ban-list and --enable-dns-blocklist. Sir. What is the diff between a banlist and a blocklist?
-
rbrunner
Well, such things have at least one positive side-effect: Hopeful new devs who want to start with Monero always find something to do :)
-
rbrunner
"diff between a banlist and a blocklist" Isn't that clear? 2 letters less.
-
ofrnxmr
:D
-
ofrnxmr
what about ban time and block time and block time?
-
ofrnxmr
"one block time is 2min, the other is how long to ban a peer"
-
m-relay
<0xfffc:monero.social> Yes, the word block has many meaning in this context.
-
rbrunner
Ah, now I see.
-
moneromooo
Please do not use the word "context" except in the sense of data attached to a peer network connection. It is confusing.
-
moneromooo
It forces me to attach context to a word. Which is... AAAAH I just did!
-
xFFFC0000
moneromooo: touché
-
m-relay
<oxetn:matrix.org> i made a monero dicing bot, if anyone wanna test
t.me/monerocasinobot
-
m-relay
<oxetn:matrix.org> min bet is 0,001 XMR