-
m-relay
<321bob321:monero.social> * Thanks Sleepy Joe
-
m-relay
<syntheticbird:monero.social> Joe joe, can you pardon kewbit please
-
binarybaron
Hi, we are trying to migrate from monero-wallet-rpc to native wallet2 bindings (using monero_c, a C wrapper around wallet2). I'm trying to move from a HTTP call to check_tx_key to a C call to MONERO_Wallet_checkTxKey. However I'm a bit unsure why there is a difference between the two. check_tx_key takes a txid, tx_key and address and gives me back
-
binarybaron
confirmations and the received amount. MONERO_Wallet_checkTxKey however takes all 5 and only returns a boolean?
-
binarybaron
-
binarybaron
-
binarybaron
-
binarybaron
Probably a mistake in the monero_c wrapper code? MONERO_Wallet_checkTxKey should take a reference instead of value?
-
m-relay
<syntheticbird:monero.social> probably better to ask in #monero-dev-community since Czarnek which i believe to be the author is there
-
selsta
-
binarybaron2
Suppose I wanted to build on top of monero-cpp and build a wrapper. Which should I use? simplewallet.h, wallet2.h or wallet2_api.h?
-
binarybaron2
by monero-cpp I mean the normal monero core repo
-
m-relay
<woodser:monero.social> would recommend wallet2.h for now
-
m-relay
<woodser:monero.social> wallet2_api.h was created for the gui, though I hear they're working on porting all functionality to that
-
m-relay
<woodser:monero.social> simplewallet.h is for simple command line tool
-
moneromooo
wallet2_api is a gratuitous extra api for no good reason (apart from thr async stuff it adds, which does add value).
-
moneromooo
But the redefinition of structures is just... wtf...
-
binarybaron2
Is wallet2_api.h being used in the GUI yet? We are basically doing what the GUI is doin (wallet functionality and a few other things) but in Rust
-
moneromooo
It is.
-
binarybaron2
As far as I understood wallet2_api.h is going to act as a compatability layer for the upcoming hardfork?
-
binarybaron2
74 | SL(boost::asio::io_service::work);
-
binarybaron2
| ~~~~~^
-
binarybaron2
/Users/me/code/monero-wrapper/monero-cpp/src/debug_utilities/object_sizes.cpp:62:39: note: expanded from macro 'SL'
-
binarybaron2
62 | #define SL(type) sl.add(#type, sizeof(type))
-
binarybaron2
Anyone know how to fix this build error?
-
m-relay
<rbrunner7:monero.social> The "Wallet API completion PR" is quite advanced already and ready for review:
monero-project/monero #9464
-
m-relay
<rbrunner7:monero.social> I am well aware that the move from wallet2 to the Wallet API does not make everybody sing with joy, but hey, still cementing the monster that is wallet2 further, in 2025? Come on :)
-
m-relay
<rbrunner7:monero.social> Especially when you more or less have free choice, like binarybaron2 may have now
-
m-relay
<rbrunner7:monero.social> "As far as I understood wallet2_api.h is going to act as a compatability layer for the upcoming hardfork?" Don't think so, not yet for the very next hardfork.
-
m-relay
<rbrunner7:monero.social> The Seraphis Wallet Workgroup had the very ambitious and ultimately failed plan to replace wallet2 not by the Wallet API, but something brand new, with the goal to remove wallet2 already with the hardfork to Seraphis. Didn't get very far ...
-
m-relay
<jeffro256:monero.social> selsta: yes, sorry I meant to earlier, but got distracted