<c​ryptocreed:matrix.org> Hi everyone,

<c​ryptocreed:matrix.org> I'm Karun, a developer with experience in C and C++, specializing in optimizing high-performance applications. I also have a background in DevOps and cloud technologies, as well as web development using JavaScript and Node.js.

<c​ryptocreed:matrix.org> I’ve been exploring the repositories and am eager to contribute by addressing existing issues or improving the codebase. Any guidance on where to start or areas that need attention would be greatly appreciated. Looking forward to collaborating with all of you!

<c​ryptocreed:matrix.org> Thank you!

Hi. My usual guidnace to start with monero is: use the software, find small bits that annoy you, and improve them.

It gives you small enough tasks to do, with a personal goal to give you some drive to finish it.

And you learn what's where along the way.

<r​brunner7:monero.social> Karun : You say "specializing in optimizing high-performance applications". Well, looks like we do have a need for some optimizations soon, and we even intend to hold a contest where people can submit their improved solutions and win some prize.

<r​brunner7:monero.social> For background you may check the log of the last MRL (Monero Research Lab) meeting here: monero-project/meta #1145

<r​brunner7:monero.social> From one of the links there: "The goal of this contest is to provide optimized implementations of helioselene and ec-divisors"

<r​brunner7:monero.social> Not sure, that may mean coding stuff in Rust however, not C / C++

.merge+ 9467 9456 9671 9538 9723 9708

Added

vtnerd: could this be related to the recent network code changes? github.com/monero-project/monero/ac…ob/36173269466?pr=9723#step:11:1380

it only fails sometimes

ofrnxmr: can you look at 9467, need it for fcmp++. others would be helpful too.

<s​yntheticbird:monero.social> tobtoht_ the general rule of thumb is that if hinto approved your PR you can be proud of you

<s​yntheticbird:monero.social> tobtoht\_: The general rule of thumb is that if hinto approved your PR you can be proud of you

ok, i want a show of hands. is there anyone besides ofrn who objects to me merging QUEUED prs if they are my own?

we're doing rough consensus now

<o​frnxmr:monero.social> Well the first step there would be to open a pr to change the rules

<s​yntheticbird:monero.social> i knew it

<s​yntheticbird:monero.social> you gave me dopamine

<o​frnxmr:monero.social> cant just be all unprofessional with it. I dont have a problem with prs for CI or like luigi worked it "duh" prs. But there should be a documented process for anything else

<o​frnxmr:monero.social> Currently that process is min 7 days + dont merge your own unless exceptional circumstances (and more, but this is the gist)

<s​yntheticbird:monero.social> was there a PR to behin with that establish the "maintainer PRs must be reviewed by ofrnxmr and ofrnxmr only"? tobtoht_ relying on hinto's approval isn't unprofessional since hinto is completely competent and collaborate on Guix.

<o​frnxmr:monero.social> no, i never asked for that either

<o​frnxmr:monero.social> Hinto's approval doesnt supercede anything else, nor does mine

<o​frnxmr:monero.social> there are some of these prs that have 3 or 4 approvals, and are "duh"

<o​frnxmr:monero.social> some of them have 1 approval and are somewhat less than "duh"

<s​yntheticbird:monero.social> I'm just notating that your suggestion of "pr to change the rules" make no sense.

<o​frnxmr:monero.social> Explain?

<o​frnxmr:monero.social> the rules (on the repo, in contributing.md) say 7 days and dont merge your own

<s​yntheticbird:monero.social> as for the PR in itself, it's a relatively minor one, its not "duh", hinto validated it, tobtoht_ should be free to merge it without waiting on your review

<s​yntheticbird:monero.social> Oh

<o​frnxmr:monero.social> It has 3 approvals. Not just hinto's

<s​yntheticbird:monero.social> Selsta just added it after tobtoht_ asked

<s​yntheticbird:monero.social> Last commit was a month ago, so even the contributing.md doesn't apply here

<s​yntheticbird:monero.social> mind explaining where is the issue here?

<o​frnxmr:monero.social> 3 approvals is 1 more than the 2 needed, and the pr is old. I'd argue on that basis that its similar to if it was written by someone else and has 2 approvals

<o​frnxmr:monero.social> Not merging your own prs is in the md. But as i said in my last msg, i think the third "valid" approval might be fair to bypass that rule

<s​yntheticbird:monero.social> Ok so you are arguing that for a maintainer to merge its own PR, it should be validated by 3 different people, is that right?

what do we think of this language: "Maintainers MUST NOT merge their own patches unless they were added to the merge queue on irc and have at least 2 approvals from contributors."

<o​frnxmr:monero.social> 3 if own imo

<o​frnxmr:monero.social> 2 for not your own

do we count selsta adding to the queue as an implicit approval?

<o​frnxmr:monero.social> thats a question for selsta. I dont think so though

<s​yntheticbird:monero.social> selsta isn't overlooking, I would count it as a valid review

<o​frnxmr:monero.social> selsta adds things to queue based on approval of others. Selsta reviews prs and leaves approval on the pr when necessary

adding to the queue is not an approval from me

i approve them explicitly

ok

<s​yntheticbird:monero.social> selsta ofrnxmr thumbs you up

so queue + 3 approvals?

<s​yntheticbird:monero.social> why would the queue be relevant. Isn't all prs supposed to be in the queue to be merged

<o​frnxmr:monero.social> For own, that sounds sane, yes

<o​frnxmr:monero.social> 4 parties minimum to a pr

<s​yntheticbird:monero.social> my bad i misunderstood, fwiw I thought tobtoht_ you were only talking of 9467. So yeah I'm against you merging all your own PRs.

<o​frnxmr:monero.social> [@jeffro256:monero.social](https://matrix.to/#/@jeffro256:monero.social) [@jberman:monero.social](https://matrix.to/#/@jberman:monero.social) [@jberman:matrix.org](https://matrix.to/#/@jberman:matrix.org) [@0xfffc:monero.social](https://matrix.to/#/@0xfffc:monero.social) [@vtnerd:monero.social](https://matrix.to/#/@vtnerd:monero.social) ^

<s​yntheticbird:monero.social> @room directly at this point

<s​yntheticbird:monero.social> @everyone

<s​yntheticbird:monero.social> call them on their personal phone number too

<h​bs:matrix.org> Sending immediate smoke signals

<d​arkhappyman:monero.social> how to use the software ?

<s​yntheticbird:monero.social> okay grandpa let's get you to bed

<d​arkhappyman:monero.social> 🚶‍♂️🛌

<d​arkhappyman:monero.social> Nooo please noo

<d​arkhappyman:monero.social> I can give you some stagenet monero’s