.merges

.merges

done

<a​ck-j:matrix.org> @binaryfate would you be able to review this PR to provide fixes for the oss-fuz integration? Plowsof was the first reviewer but two are required

<a​ck-j:matrix.org> google/oss-fuzz #13691

<o​frnxmr:monero.social> Asking binaryfate is crazywork :D

<o​frnxmr:monero.social> I'd leave that invitation more "open"

<a​ck-j:matrix.org> Anyone is welcome and encouraged to review but the github bot said “The PR must be approved by known contributors before it can be merged. The past contributors are: plowsof, maflcko, inferno-chromium, binaryFate”

<o​frnxmr:monero.social> That pr is still marked as a draft

<o​frnxmr:monero.social> i saw that, but does that mean known contributors to oss-fuzz? I think it would imply known contributors, including trusted members upstream

<o​frnxmr:monero.social> Anyway, comments from me: 1. is the ci supposed to be green? 2. i dont like the merge commit 3. Its marked as draft

<o​frnxmr:monero.social> [@xmrack:monero.social](https://matrix.to/#/@xmrack:monero.social)

<o​frnxmr:monero.social> google/oss-fuzz #12936

<o​frnxmr:monero.social> you can see here that selsta and myself approved plowsof's contribution

<o​frnxmr:monero.social> (you commented there as well). This just to say that the bot's recommendations arent concrete

<a​ck-j:matrix.org> I believe CI fails since pr #10004 hasnt been pushed to master

<a​ck-j:matrix.org> *merged

<o​frnxmr:xmr.mx> That might be the same reason it's in draft (waiting for 10004?)

<a​ck-j:matrix.org> Yea

<a​ck-j:matrix.org> From that PR it looks like any monero contributor can approve. So I extend the invitation to everyone here :D

<o​frnxmr:xmr.mx> Are the adalogics guys going to maintain this long term? I see they were added to the `auto cc` contacts alongside the fluffy, binary, luigi, and mooo.

<a​ck-j:matrix.org> Their emails would only be temporary so they can thoroughly debug the new harnesses over the next few weeks

<a​ck-j:matrix.org> I’ll paste my comment advocating for their addition a few MRL meetings ago:

<a​ck-j:matrix.org> The benefit of adding david from adalogics (temporarily) to the email list of OSS-Fuzz is that his team will be able to more effectively troubleshoot the harnesses as they can potentially hit edge cases and need to be updated. Monero’s OSS-Fuzz integration has been neglected for a while now and having david (the #1 contributor to the OSS-Fuzz project) making sure everything is r<clipped message>

<a​ck-j:matrix.org> unning smoothly would IMHO be a great asset to the monero community.

<o​frnxmr:xmr.mx> tobtoht should the dependencies be cleaned up here (in dockerfile)

<o​frnxmr:xmr.mx> xmrack monero-project/monero #9989