-
dabbonda
Hi, I opened my first pull request fixing a minor warning:
monero-project/monero #10088
-
dabbonda
Im trying to join monero dev on matrix but getting "Registration has been disabled on this homeserver.
-
dabbonda
". Let me know if I should/need to just choose a different home server before joining.
-
m-relay
<drinksomemilk:matrix.org> Registration on the homeserver is disabled you have to choose a diffrent homeserver unfortunatly
-
sandbeach123
Is it safe as a lightweight method to detect a payment, to query with json rpc a node (public node) in the following steps: 1. Get current height 2. Get transaction hashes from last block. Then for each transaction: 3. Get transaction public key and decode outputs using private view key looking for a match (recipient subaddress and amount)?
-
DataHoarder
complaint about check_tx_proof
-
DataHoarder
$ echo -n "OutProofV22tNdKUEy8Zc8wyMxVECS6C3eYAA9P7tCribN31YZ2VbTahBJgv6RYaJHJGwHCS6cDXKFXuQQx8Nu2U7EEjeDq5EiSx9WtFmUyrHFLF88zsDybhigkMtzTmq8K6CobZHbSWT3" > proof.txt
-
DataHoarder
check_tx_proof 68890618e2331fa771664479d36b7895bbf9dd89985ed260afc6129959258b52 48XXcXEC1b79VBjUAKSM5EX5jBDHdkraPRpjVFBUz7yv5sDXWVCvPdQBx53uAqHsifXaPBgtQJm4dTutNCZoR2ZT2tQh36i proof.txt
-
DataHoarder
this is silly. first proof.txt cannot have newlines or spaces
-
DataHoarder
then proof.txt is always one of these OutProof/InProof etc. versioned strings
-
DataHoarder
why can't the last arg on check_tx_proof also accept one of these directly?
-
DataHoarder
(or at least accept newlines, so nano/other editors that add newlines can be used to make this file)
-
m-relay
<ofrnxmr:xmr.mx> Not accepting newlines sounds unintended
-
m-relay
<ofrnxmr:xmr.mx> Ending a file with a newline = posix compliant
-
DataHoarder
On GUI there's just fields for all of it
-
DataHoarder
-
DataHoarder
-
DataHoarder
> Place the signature proof on a file, then call check_tx_proof in CLI. Ensure no newlines or spaces exist on the file.
-
m-relay
<ofrnxmr:xmr.mx> Does it have to be in a file?
-
DataHoarder
it has to be in a file
-
DataHoarder
Error: usage: check_tx_proof <txid> <address> <signature_file> [<message>]
-
DataHoarder
if I try <signature_file> with the OutProofV2
-
DataHoarder
Error: failed to load signature file
-
DataHoarder
if there are newlines/spaces in file
-
DataHoarder
Error: error: Wrong signature size
-
m-relay
<hbs:matrix.org> What is the correct way to generate checksums for Monero addresses? I've tried the pycryptodome keccak implementation in Python, and the js-sha3 keccak_256 implementation in JavaScript but I've bumped into a specific set of public Spend and View keys which doesn't generate the correct checksum when using those libraries compared with the checksum from luigi1111 at
xmr.llco<clipped message>
-
m-relay
<hbs:matrix.org> ins.net/addresstests.html
-
luigi1111
only that pair or did you try others
-
luigi1111
they should either all work or none work
-
DataHoarder
keccak_256, take 4 bytes out little endian
-
m-relay
<hbs:matrix.org> This pair specifically, that's what's odd!
-
DataHoarder
-
DataHoarder
got the pair?
-
DataHoarder
or address itself
-
m-relay
<hbs:matrix.org> The content 12279d2ada9e7c509981294e0226d245a0a2dbd2b69027fa1c4d626f2f6482d28056fdc7b6999bf479544f59b3bf8ccb1f1520589f76119103278af415789e17b1 is hashed to 82feb5cebaa109fe7763eb312ecfca468005638eb909bf2ed7050c69c6f9625d by both the JavaScript and Python libraries but to fa88ac85b8e59ea58312e02ca657aa6d49787be23e7603860cc40f54164a1ad4 by your checker
-
m-relay
<hbs:matrix.org> For other pairs chosen at random the checksums match
-
DataHoarder
so spend key 279d2ada9e7c509981294e0226d245a0a2dbd2b69027fa1c4d626f2f6482d280 view 56fdc7b6999bf479544f59b3bf8ccb1f1520589f76119103278af415789e17b1 ?
-
m-relay
<hbs:matrix.org> yes
-
DataHoarder
sadly 82feb5ce is correct in my implementation
-
DataHoarder
that gives 438BFq9hJfHSgBogkksBMvTsNaY9czwv95jZvQdTH7EhNU4JUvtGcEoMJ3hZc5zQoU6CYHdXwJZwE1XbvyfLvECEM2aHs3b
-
m-relay
<hbs:matrix.org> Then you will also generate an address which will be invalid in some wallet (Feather and Cake for example)
-
DataHoarder
14. Checksum: 82feb5ce Does #14 equal #11? Yes! This is a valid Standard XMR address.
-
DataHoarder
-
m-relay
<hbs:matrix.org> You cannot send XMR to that address using Cake Wallet for example
-
DataHoarder
-
DataHoarder
mine uses golang's sha3 Keccak256
-
m-relay
<hbs:matrix.org> Then I need to triple check the base58 encoding, it might be wrong and flip some bits
-
m-relay
<ofrnxmr:xmr.mx> "<DataHoarder> this is silly. first proof.txt cannot have newlines or spaces" << yeah, lol. get_tx_proof even creates a file that doesnt end in a newline
-
DataHoarder
remember it's as-is
-
DataHoarder
don't read the checksum to uint32 :D
-
DataHoarder
> to fa88ac85b8e59ea58312e02ca657aa6d49787be23e7603860cc40f54164a1ad4 by your checker
-
m-relay
<hbs:matrix.org> Comparing with your address, it seems the base58 padding is incorrect in the one I generated, so this is probably the root cause, intrducing bit flips I did not spot
-
m-relay
<hbs:matrix.org> Thanks for taking the time to check, I'm going back to the drawing board....
-
DataHoarder
past me helps again by overimplementing things :)
-
DataHoarder
I can also try to decode them, if you have the address :)
-
m-relay
<hbs:matrix.org> Ok the issue was in the base58 padding which incorrectly padded the block at the wrong end!
-
m-relay
<r4v3r23:monero.social> upgraded from v0.18.3.3 to 18.4.2, has daemon connection code been changed in any way? getting a lot of "no connection to daemon" errors when trying to build txs (daemon is connected and synced)
-
m-relay
<r4v3r23:monero.social> also getting a very strange error:
-
m-relay
-
m-relay
<ofrnxmr:monero.social> Maybe node issue?
-
m-relay
<rucknium:monero.social> IIRC, `--rpc-max-connections` was added in 0.18.4.0
github.com/monero-project/monero/releases/tag/v0.18.4.0
-
m-relay
<sneedlewoods_xmr:matrix.org> DataHoarder here is a patch, so now you can use `check_tx_proof <txid> <address> proof=<proof>` and it also strips whitespace when loaded from file
paste.debian.net/1397565
-
DataHoarder
Yeah it's more for end users :D
-
m-relay
<sneedlewoods_xmr:matrix.org> can also make a PR
-
DataHoarder
that'd be nice
-
DataHoarder
I mean why not check if the proof starts with InProof/OutProof instead of proof=?
-
DataHoarder
check_spend_proof and check_reserve_proof are different commands and those make sense having the file alternative
-
DataHoarder
(the proofs are huge)
-
m-relay
<sneedlewoods_xmr:matrix.org> the file could be named InProof.txt or something
-
DataHoarder
InProofV2 yeah etc.
-
DataHoarder
try decoding, if that fails, decode file?
-
DataHoarder
file could be named proof=.txt :)
-
m-relay
<ofrnxmr:xmr.mx> Thats on node (ans wallet-rpc) side though. Updating wallet_api shouldn't have changed anything
-
m-relay
<sneedlewoods_xmr:matrix.org> good point :D
-
selsta
r4v3r23: does it work after retrying a couple times?
-
bdlinick
Hi all. I'm bdLinick. I'm a security engineer who's passionate about Monero
-
bdlinick
and just want to start contributing more. Just opened my first PR (fuzz tests
-
bdlinick