Hi

can't compile release-v0.18 on latest fedora 43, command_line.h:187:8: error: definition with same mangled name '_ZN12command_line7add_argIbLb0ELb0ELi1EEEvRN5boost15program_options19options_descriptionERKNS_14arg_descriptorIT_XT0_EXT1_EXT2_EEEb' as another definition

(somehow seraphis fork does work?)

<o​frnxmr:xmr.mx> Fcmp fork is of master

yeah, but this is old code (last touched 2018)

<v​tnerd:monero.social> I got this with clang-21 the other day. The fix isn't too bad, I'll issue a pr

untouched in fcmp

got a patch meanwhile for it?

<v​tnerd:monero.social> Yeah just remove the `template<>` line and make the third parameter optional by defaulting to false

<v​tnerd:monero.social> Hold on

<v​tnerd:monero.social> Or make it true sorry

<v​tnerd:monero.social> ```

<v​tnerd:monero.social> ```

<v​tnerd:monero.social> diff --git a/src/common/command_line.h b/src/common/command_line.h

<v​tnerd:monero.social> index 681eb903b..a8a718012 100644

<v​tnerd:monero.social> --- a/src/common/command_line.h

<v​tnerd:monero.social> +++ b/src/common/command_line.h

<v​tnerd:monero.social> @@ -207,8 +207,7 @@ namespace command_line

<v​tnerd:monero.social> description.add_options()(arg.name, make_semantic(arg, def), arg.description);

<v​tnerd:monero.social> }

<v​tnerd:monero.social>

<v​tnerd:monero.social> - template<>

<v​tnerd:monero.social> - inline void add_arg(boost::program_options::options_description& description, const arg_descriptor<bool, false>& arg, bool unique)

<d​atahoarder:monero.social> ^

<d​atahoarder:monero.social> ```

<d​atahoarder:monero.social> monero/src/common/command_line.h:211:126: error: redefinition of default argument

<d​atahoarder:monero.social> 211 | inline void add_arg(boost::program_options::options_description& description, const arg_descriptor<bool, false>& arg, bool unique = true)

<d​atahoarder:monero.social> | ^ ~~~~

<d​atahoarder:monero.social> monero/src/common/command_line.h:187:140: note: previous definition is here

<d​atahoarder:monero.social> 187 | void add_arg(boost::program_options::options_description& description, const arg_descriptor<T, required, dependent, NUM_DEPS>& arg, bool unique = true)

<d​atahoarder:monero.social> ```

<v​tnerd:monero.social> lol so much for an easy fix. what compiler is this?

<d​atahoarder:monero.social> clang 21.1.8

<v​tnerd:monero.social> let me double check what I did previously, this was from memory

<v​tnerd:monero.social> I dont know, this works with clang 21.1.8 on gentoo

<v​tnerd:monero.social> was the `template<>` removed? I get that error if that line is not removed

<d​atahoarder:monero.social> right, I didn't remove it