-
selsta.merge+ 10318 10319
-
xmr-prAdded
-
selstaany opinion on PRs like this? monero-project/monero #10326 clearly AI generated but would add test cases
-
selstaseems to be quite low level tests of things that are unlikely to break
-
sech1Okay, I approved another PR because it was a single line change. But this... They need to pay us to review this...
-
sech1As for tests: don't accept new test just for the sake of tests. New tests should be added together with an entirely new code, or together with bugfixes - i.e. a test that makes the old code fail + the code fix
-
sech1and yes, it's a PR from the same "team": gittensor.io/miners/repository?name=monero-project%2Fmonero (click on "Pull Requests" tab)
-
selstaok i will close it, also it did not even disclose the fact it's AI
-
m-relay<rbrunner7:monero.social> Cool, that 'combinations_count' method really needs some tests. With priority :)
-
m-relay<rbrunner7:monero.social> That "gittensor" thing at a quick glance looks like some sort of contest?
-
m-relay<rbrunner7:monero.social> "Who can get the most PRs merged into the highest-ranking projects"
-
tobtoht.merges
-
xmr-pr10299 10312 10314 10315 10316 10317 10318 10319
-
tobtohtdone
-
selstathanks! is there anything missing for monero-project/monero #10308 ?
-
selstaotherwise I'll ask for a tag in the next days