<b​asses:matrix.org> does monero require contributers to sign their commits?

<o​frnxmr:xmr.mx> No

<b​asses:matrix.org> why

<o​frnxmr:xmr.mx> Why would it

<o​frnxmr:xmr.mx> We merge code from anyone, not just paranoid ppl

<o​frnxmr:xmr.mx> and nobody is allowed to push directly to the repo. Gpg signing is a nice to have, but really only makes a difference for repos that have people commiting directly to them

<g​gdev:mdev.nutra.tk> it's not hard to make a key. No harder or crazier than washing hands before meals.

<g​gdev:mdev.nutra.tk> Can you guys offer suggestions/feedback on PRs to feather or cake?

<b​asses:matrix.org> only core do push, right?

<b​asses:matrix.org> and they sign their commits?

<o​frnxmr:xmr.mx> They dont

<o​frnxmr:xmr.mx> [#monero-community-dev:monero.social](https://matrix.to/#/%23monero-community-dev:monero.social)

<b​asses:matrix.org> bruh, they should

<o​frnxmr:xmr.mx> they dont push to the repo*

<b​asses:matrix.org> oh ok.

<o​frnxmr:xmr.mx> They go thru prs as well

<o​frnxmr:xmr.mx> You could say that its preferred that people sign their commits, but _nobody_ is checking, and we dont even require you to use git. You can send code via a pastebin

<b​asses:matrix.org> I actually checked pushes github.com/monero-project/monero/commits/master known developers sign their commits, except some other community contributors

<b​asses:matrix.org> matrix.monero.social/_matrix/media/…matrix.org/uhlluuoGlmnWthnxpIxNZZKq

<o​frnxmr:xmr.mx> Navid and vtnerd are known devs

<b​asses:matrix.org> shows "Verified" if they sign commits

<o​frnxmr:xmr.mx> matrix.monero.social/_matrix/media/…oad/xmr.mx/VQyqcDgXIAvwaRusIustdGNO

<b​asses:matrix.org> would be good if they sign their commits then

<b​asses:matrix.org> click on 3 dots

<o​frnxmr:xmr.mx> Yeah, some sign (tob), some sign sometomes (jeffro), some dont sign ( a bunch more)

<o​frnxmr:xmr.mx> ? Its not signed

<b​asses:matrix.org> yeah, indeed, weird as his latest commits are signed

<g​gdev:mdev.nutra.tk> i'm sure impersonating someone is fairly rare, and in serious cases, might be punishable

<o​frnxmr:xmr.mx> matrix.monero.social/_matrix/media/…oad/xmr.mx/juANMhWaQmEXMdQEkdcRKvsv

<b​asses:matrix.org> actually majority of his commits

<g​gdev:mdev.nutra.tk> in any case the devs all sign a deterministic guix build at least for feather

<o​frnxmr:xmr.mx> Nobody cares - the prs are reviewed

<g​gdev:mdev.nutra.tk> ya its just a formality or extra security measure for nerds ig

<o​frnxmr:xmr.mx> We sign deterministic gitian builds for monero

can you move this conversation to another channel

<b​asses:matrix.org> not rare, and you can't punish if you are not enforcing commit signing

#monero

<g​gdev:mdev.nutra.tk> anyway my request not tonight another time, but i have a tricky PR in the works for feather/cake that's almost a hybrid between offline and continuous sync

<g​gdev:mdev.nutra.tk> which after i started working on it, started feeling so wrong, like paddling up river. But it's a convenience factor, too

<o​frnxmr:xmr.mx> [#monero-community-dev:monero.social](https://matrix.to/#/%23monero-community-dev:monero.social) [@ggdev:mdev.nutra.tk](https://matrix.to/#/@ggdev:mdev.nutra.tk)

<s​weetkanoe:matrix.org> why is every stagenet xmr faucets down bru

<s​weetkanoe:matrix.org> even the stagenet explorer is down

<s​weetkanoe:matrix.org> @plowsof - Hey, just wanted to ping you here since I saw you're in this group. I posted my completed RoboSats-XMR fork on the bounty page a few hours ago (2.009 XMR bounty). 12/12 tests passing, code's on GitHub, everything's done except I need a tiny bit of stagenet XMR to finish end-to-end testing. Could you take a look when you have a moment? Thanks!

<s​weetkanoe:matrix.org> plowsof - Hey, just wanted to ping you here since I saw you're in this group. I posted my completed RoboSats-XMR fork on the bounty page a few hours ago (2.009 XMR bounty). 12/12 tests passing, code's on GitHub, everything's done except I need a tiny bit of stagenet XMR to finish end-to-end testing. Could you take a look when you have a moment? Thanks!

<r​brunner7:monero.social> sweetkanoe: Please drop your stagenet address here, I will send something

<s​weetkanoe:matrix.org> 57AMFjwXiSS39p4WU7zFNKZ3RKopHjnta1sTP75FhHK5GrJ2uGu3LELSEF3F6LirwNXyuQxuw6uGABQH9No1UsurE6136ko

<s​weetkanoe:matrix.org> thanks :)

<j​babb:cypherstack.com> 926830119ed33ddc2d00c3a11d0759beae5895ad09fc5cb8050a6b285b30ffdf

<o​frnxmr:xmr.mx> Monero Bounties

<s​weetkanoe:matrix.org> idk why but i havent received it like fr, i also tried a faucet but it also showed sent but i didnt recieve that either

<j​babb:cypherstack.com> 7 confirmations, idk

<j​babb:cypherstack.com> some sync issue

<s​weetkanoe:matrix.org> ah prob yeah, i will wait i guess

<o​frnxmr:xmr.mx> Are you connected to a node..?

<j​babb:cypherstack.com> what's your stagenet height? it's in block 2067633, you should have it...

<s​weetkanoe:matrix.org> yep that was the error

<s​weetkanoe:matrix.org> no daemon connected

<s​weetkanoe:matrix.org> am dumb

<j​babb:cypherstack.com> I mined you some coinbases that will have a locktime 60, hope your code handles edge cases >:D

<s​weetkanoe:matrix.org> lol

sweetkanoe: How did you test it on stagenet/testnet before submitting to the bounty?

Since you didn't have stagenet coins

<s​weetkanoe:matrix.org> i tested it on stagenet by running monero-wallet-rpc in stagenet mode and connecting to public nodes. faucets were all down so i asked around in the monero matrix rooms and someone sent me a bit of stagenet xmr to work with. the robosats fork uses that rpc for everything — generating subaddresses, handling 10-block locks, checking balances, sending between wallets. all 12 tests <clipped message>

<s​weetkanoe:matrix.org> pass. just waiting for the wallet to sync so i can finally run an actual trade from end to end.

<s​weetkanoe:matrix.org> am sure i got enough time before he tests the code

<o​frnxmr:xmr.mx> Were way off topic

<o​frnxmr:xmr.mx> Nove to bounties room plz, or Monero Community Dev

<s​weetkanoe:matrix.org> sorry for that, again.

<s​weetkanoe:matrix.org> got the xmr, thanks dude u saved me big time

<j​babb:cypherstack.com> np bruv frfrf