-
m-relay_<jpk68:matrix.org> Is it discouraged for new core code to use Boost libraries? What is the consensus around whether Boost/epee/STL should be used for different things?
-
moneromoooSTL is standard, and good. Use it when you can. Not super new stuff though. Boost has nice stuff STL does not. If overlap, if in doubt, use whatever the code you're modifying uses. If it uses nothing, whatever monero overall uses. If none, STL.
-
moneromoooSome people really dislike epee, but I would use the same logic as above really. Just don't go out of your way to use it.
-
moneromoooThere may be special policies for the new wallet code specifically, I wouldn't know.
-
moneromoooAnd I'd try to keep down on fancy template code. It can get unmaintainable by anyone else than the writer, which isn't good.
-
m-relay_<jpk68:matrix.org> Thanks :)
-
m-relay_<jpk68:matrix.org> I can see why some people dislike epee, haha
-
m-relay_<jeffro256:monero.social> I would say that Boost serialization specifically is discouraged in new code
-
m-relay_<alex_005_005:matrix.org> Because the less wrappers, the better and cleaner the code?
-
m-relay_<jeffro256:monero.social> Because it's not a great format for any specific reason, and it has almost non existent support in the broader ecosystem
-
m-relay_<jeffro256:monero.social> And it's not currently used for any important functions even in our codebase besides the p2p peer list file
-
moneromoooboost serialization is buggy and a probable security issue. I've seen it crash, and could not understand the code. We have better anyway. It's now used only for wallet stuff IIRC, which is not attacker controlled.
-
azerxHi guys, does monero core wallet support the latest trezor now?
-
azerxThe bloody Ledger stax still resets with monero wallet so i need to stop using it with ledger
-
m-relay_<jpk68:matrix.org> I believe not
-
m-relay_<jpk68:matrix.org> monero-project/monero-gui #4567#issuecomment-3921948795
-
azerxok thanks, have to use local wallet i guess for now