-
m-relay<vtnerd:monero.social> Am I supposed to respond on GH or codeberg? It's going to be funky if you can't respond directly on GH
-
m-relay<jpk68:matrix.org> Yeah, sorry about that. Whatever works for you
-
m-relay<jpk68:matrix.org> GH is fine, or just Matrix
-
m-relay<jpk68:matrix.org> Unless you happen to have a Codeberg account already or something
-
m-relay<ofrnxmr:xmr.mx> Id say to put review comments directly on github
-
m-relay<jpk68:matrix.org> Thanks, made some fixes. I think the mirror will have to be manually updated
-
m-relay<jpk68:matrix.org> cc ofrnxmr
-
m-relay<jpk68:matrix.org> I ended up adding a runtime check (before the second review comment), but I can still change it if you'd like
-
tobtohtgiven that there is no support to remove miniupnpc outright (#10012) and a replacement won't be ready soon, I would like to request review of #9273, which updates it and moves it to depends.
-
m-relay<ofrnxmr:xmr.mx> I find it utterly useless. Does _anyone_ even have success with it?
-
m-relay<ofrnxmr:xmr.mx> Its quite literally worked for ne zero times across probably 10 routers. Manual port forwarding always required
-
tobtohtI would still prefer to just remove it. If it doesn't work (reliably), it's just a maintenance burden and vulnerability liability for nothing.
-
m-relay<ofrnxmr:xmr.mx> I vote to remove it.. useless garbage
-
m-relay<ofrnxmr:xmr.mx> Imo
-
tobtohtok, I will update 10012
-
selsta.merge+ 10449
-
xmr-prAdded
-
selsta.merge+ 10461
-
xmr-prAdded
-
selstais anyone here against removing upnp support?
-
m-relay<syntheticbird:monero.social> no one has ever been for upnp in the first place
-
m-relay<syntheticbird:monero.social> i beg you
-
m-relay<syntheticbird:monero.social> get rid of it
-
m-relay<ixr3:matrix.org> Yes remove
-
m-relay<ravfx:xmr.mx> Nuke it!
-
selsta.merge+ 10454 10455 10459
-
xmr-prAdded
-
m-relay<ixr3:matrix.org> @selsta the v0.18.5.0 release to-do list looks great
-
selstahope we can get it out next week