libera #monero-dev

16 May 2026

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Monero GUI dev is at #monero-gui || Monero website dev is at #monero-site || Non-dev questions -> #monero, please || No fork help, you’re on your own

• 00:42
  br-m
  <jpk68:matrix.org> selsta: I might be missing something, but is there a reason I should include <string_view> if it compiles without it?
• 00:42
  br-m
  <jpk68:matrix.org> (responding to your review comment)
• 00:44
  selsta
  If you use it and it's not included in the .cpp or .h I'd include it
• 00:45
  br-m
  <vtnerd> It's useful for compatibility purposes. Omitting it is relying on particular libraries to indirectly include the feature
• 00:45
  selsta
  in the past we had builds failing suddenly because some compiler suddenly got more strict
• 00:47
  br-m
  <jpk68:matrix.org> Thanks, good to know
• 00:52
  selsta
  jpk68: there are open PRs regarding man pages, just pointing it out so that you don't duplicate work
• 00:52
  br-m
  <jpk68:matrix.org> I know, mine is for monero-wallet-cli specifically, not the daemon, as the others are for
• 00:53
  br-m
  <jpk68:matrix.org> Thanks for the heads-up, though :)
• 00:55
  br-m
  <jpk68:matrix.org> Not counting the one PR that had them converted with Pandoc, I mean
• 01:19
  br-m
  <jpk68:matrix.org> Alright, I pushed fixes and added a test case for incorrect version byte. The mirror might take a bit to get updated but that's fine
• 01:20
  br-m
  <jpk68:matrix.org> Somehow also just realized that every (valid) onion address ends with "d" :P
• 17:58
  br-m
  <jpk68:matrix.org> selsta: Would you mind uploading a pastebin of the build error for 10612?
• 17:58
  br-m
  <jpk68:matrix.org> It works on my machine
• 17:59
  selsta
  it can't find the boost header
• 17:59
  br-m
  <ofrnxmr:xmr.mx> mrelay.p2pool.observer/p/n9fB24MLY3BuM1c3/1.txt (code snippet, 4 lines)
• 18:00
  br-m
  <ofrnxmr:xmr.mx> Have you benched the improvement? Is it even worth the micro optinmiization?
• 18:01
  br-m
  <jpk68:matrix.org> No, but what would be the harm in changing it? It would clearly be much slower if you included the entirety of Asio everywhere
• 18:02
  br-m
  <ofrnxmr:xmr.mx> its not clear if it doesnt build and hasnt been compared
• 18:06
  br-m
  <jpk68:matrix.org> Well, that's strange... if you look on my fork, it's a different header
• 18:06
  br-m
  <jpk68:matrix.org> monero-project/monero #10612/files
• 18:06
  br-m
  <jpk68:matrix.org> codeberg.org/jpk68/monero/pulls/15/files
• 18:08
  br-m
  <ofrnxmr:xmr.mx> Maybe sent sneed a different patch?
• 18:09
  br-m
  <ofrnxmr:xmr.mx> Youre right that the prs dont match.
• 18:09
  br-m
  <jpk68:matrix.org> Pretty sure I didn't, I just gave him the link to my fork
• 18:09
  br-m
  <jpk68:matrix.org> Anyways, I pushed a fix for the other one and both should be updated soon
• 18:48
  br-m
  <sneedlewoods_xmr:matrix.org> yeah sorry, that was my fault
• 18:49
  br-m
  <ofrnxmr:xmr.mx> You're fired
• 18:50
  br-m
  <ofrnxmr:xmr.mx> what i do.. is i just add jpks remote, then checkout the branch, then push it as-is to my repo
• 18:50
  br-m
  <ofrnxmr:xmr.mx> To my remote*
• 18:54
  br-m
  <jpk68:matrix.org> Don't worry about it
• 18:55
  br-m
  <jpk68:matrix.org> I just wanted to let people know what was going on
• 19:20
  br-m
  <that-guy123:fedora.im> Jpk, i had rights to the merkle roots verification scheme before this group. How can we resolve this?
• 19:20
  br-m
  <that-guy123:fedora.im> It seems this is an underlying schema to the functionality of the coin cryptographic protocall
• 19:22
  br-m
  <jpk68:matrix.org> Apologies if this is rude, but I have no idea what you're talking about, I am not the right person to answer this question, it sounds like you're trolling, and this is the wrong channel anyways
• 19:23
  br-m
  <that-guy123:fedora.im> Ok maybe u are the wrong individual to inquire. Who made the game? Do u know or are aware?
• 19:23
  br-m
  <jpk68:matrix.org> #monero-community:monero.social
• 19:24
  br-m
  <that-guy123:fedora.im> Eh
• 19:25
  br-m
  <jpk68:matrix.org> Please move this convo to the channel I linked above. This is the wrong channel ;)
• 19:25
  br-m
  <that-guy123:fedora.im> What do u think of the situation?
• 19:25
  br-m
  <jpk68:matrix.org> Wrong channel
• 19:25
  br-m
  <that-guy123:fedora.im> Ok
• 19:25
  br-m
  <that-guy123:fedora.im> K
• 19:58
  br-m
  <jpk68:matrix.org> selsta: What do you mean by your comment?
• 19:58
  br-m
  <jpk68:matrix.org> Nothing seems off on my end
• 19:59
  selsta
  sneedle fixed it after my comment
• 20:00
  br-m
  <sneedlewoods_xmr:matrix.org> sorry for the inconvenience, today's not my day, to my excuse I need to sleep
• 20:02
  br-m
  <jpk68:matrix.org> DW, not a big problem
• 20:02
  br-m
  <jpk68:matrix.org> Alright, looks like all three are good to go now
• 20:36
  br-m
  <jpk68:matrix.org> vtnerd: WIN32 is apparently defined in <windows.h>, or by MinGW. In any case, I'm fairly certain it's not by us
• 20:36
  br-m
  <jpk68:matrix.org> stackoverflow.com/a/74084728
• 20:40
  br-m
  <vtnerd> Then why the switch to _WIN32 ?
• 20:40
  br-m
  <jpk68:matrix.org> Because it can be defined falsely (by the user or otherwise), and requires headers
• 20:40
  br-m
  <jpk68:matrix.org> This is explained in the post I linked to above
• 20:41
  br-m
  <jpk68:matrix.org> On the other hand, _WIN32 is strictly compiler-defined and can't be messed with