.merge+ 10607

Added

<jpk68:matrix.org> vtnerd: I made some tweaks to 10554 to address review comments. I think it would be better to keep a forward decl of from_onion_v3_const in the header, to avoid rearranging half of the code in the source files

<ofrnxmr> Did u address the whitespace tho 🥴

<jpk68:matrix.org> Yes ;)

<ofrnxmr> Not pushed yet?

<jpk68:matrix.org> I guess I'll have to submit another one removing it after... more commits for me :P

<jpk68:matrix.org> Why are there random line breaks in the middle of copyright comments in the first place?

<ofrnxmr:xmr.mx> Who knows, who cares :)

<ofrnxmr:xmr.mx> Check the git blame and get mad at someone for fudging it 11 years ago

<vtnerd> @jpk68: why does the entire function need to be in the header? Why not forward declare and drop constexpr - its not constexpr is being used anywhere

<jpk68:matrix.org> I removed it in the header, yes

<jpk68:matrix.org> Sneedle just has to update the mirror

<jpk68:matrix.org> It was just originally there because it came from P2Pool

<syntheticbird> @ofrnxmr:xmr.mx: cut the blame and just get mad

<syntheticbird> 👍️

It doesn't have to be constexpr in Monero's code because it's not used to initialize any constexpr values

and it doesn't have to be in the header in this case

<sneedlewoods_xmr:matrix.org> is this fine to push? codeberg.org/jpk68/monero/pulls/13/files

<sneedlewoods_xmr:matrix.org> or should constexpr get removed first from from_onion_v3_const()

<ofrnxmr:xmr.mx> I'd waif for the update

<ofrnxmr:xmr.mx> No need to run an extra 1.5hrs of ci and store an extra 150mb of binaries

<jpk68:matrix.org> vtnerd: Do you have an opinion on the above?

<ofrnxmr:xmr.mx> @vtnerd: Didnt both of them say to drop it

<jpk68:matrix.org> Sorry, I must have misread that

<jpk68:matrix.org> My bad

.merges

9473 10084 10512 10531 10533 10543

<jpk68:matrix.org> Done.

.merge+ 10609 10610

Added