.merge+ 10796 10797

Added

<milas900:matrix.org> Probably use AI to remove > <@thomasbuilds:matrix.org> My goal with this PR is to remove all the dead code in the monero repo, what you think? monero-project/monero #10809 ?

.merges

10597 10598 10790 10796 10797

.merge+ 10824

Added

<thomasbuilds:matrix.org> @milas900:matrix.org: yes after seeing that contributors kept finding typos after my codespell cleanups I figured it would be better to use AI to tackle this fully, I set up subagents to read entire codebase in search of spelling issues and well many findings but idk if monero should address this tbh

<thomasbuilds:matrix.org> thomasbuilds/monero e8f9968

<ofrnxmr:xmr.mx> the ones that are just comments.. i say yolo the changes in

<ofrnxmr:xmr.mx> there are 2 schools of thought: 1) dont touch code / only touch comments. 2) fix everything at once

<ofrnxmr:xmr.mx> i think either way it would be a good idea to add something like codespell to check the diffs on ci runs

i'm against renaming variables, even if done at once

<thomasbuilds:matrix.org> selsta: yes though do we care about fixing typos in comments/string literals if there are still typos in variable, function names?

<thomasbuilds:matrix.org> like it seems to me the job can't be fully completed

<ofrnxmr:xmr.mx> in general, i dont think we care about fixing old spelling errors. oonly reasons to fix them, are to avoid spelling-error fix prs, or if already touching the related code

<jpk68:matrix.org> Aside from function names, I am personally in favour of fixing typos/grammar issues (which is probably not hard to tell from my past PRs)

thomasbuilds: anything that is end user facing needs to be fixed, comments can be fixed, anything else i'm against

<jpk68:matrix.org> @ofrnxmr:xmr.mx: There would be no good reason to keep things the way they were here, for example:

<jpk68:matrix.org> monero-project/monero #10447/files

<thomasbuilds:matrix.org> selsta: I'd assume you include string literals too?

if they show up for the end user somewhere yes

<jpk68:matrix.org> monero-project/monero #10828/files#diff-1791ca6db56ff6236c17c6b8c2d6bc1516adbf806345d2e0ffc3b3a1b60e8287R1461

<jpk68:matrix.org> No way, AI knows the number of "R"s in "raspberry" :D

<jpk68:matrix.org> For the last one in device_ledger.cpp, I think I tried to fix that in an earlier PR, but didn't get a response when I asked if it was supposed to be "use" or "unset"

<jpk68:matrix.org> Looking at the context, it probably is "use" but I could be wrong

<ofrnxmr:xmr.mx> It probably just ran codespell

<jpk68:matrix.org> He said he used AI since codespell left out a bunch last time

<thomasbuilds:matrix.org> haha lmao > <@jpk68:matrix.org> No way, AI knows the number of "R"s in "raspberry" :D

.merge+ 10646 10774

Added