JossieEtheridge opened pull request #10990: Fix long-standing 'Next span is not empty' sync stall (#8194)

> monero-project/monero #10990

<thomasbuilds:matrix.org> omg this PR wtf

<ofrnxmr> I also think they hit that bug because they ser block-sync-size-100

<ofrnxmr> "Measured real, successful 100-block span completions on this node taking

<ofrnxmr> 2-26 seconds each. With a 2-second threshold, any peer that goes briefly

<ofrnxmr> quiet — completely normal under real network conditions — gets its[... more lines follow, see mrelay.p2pool.observer/e/uKH9hZsLSHVET0Nx ]

<ofrnxmr> block-sync-size=100*

<thomasbuilds:matrix.org> his LLM is so bad he didn't realize he's fixing a closed issue lmao

<thomasbuilds:matrix.org> What I don't understand from github is that it included 20 participants in this PR and there are 0 reviews/comments.

<thomasbuilds:matrix.org> 20 ppl received notification for this slop PR rip

<ofrnxmr:xmr.mx> @thomasbuilds:matrix.org: Fixong like 5 closed issues from v0.12

<ofrnxmr:xmr.mx> aNd fixing a self-induced issue

<ofrnxmr:xmr.mx> And pushing release code to master

<ofrnxmr:xmr.mx> And not checking if fix is already on master

<thomasbuilds:matrix.org> lol I mean he joined github in April what can you expect

<thomasbuilds:matrix.org> this is his 1st ever contribution

<ofrnxmr:xmr.mx> @thomasbuilds:matrix.org: I only see 3

<thomasbuilds:matrix.org> now yes because he forced pushed

<ofrnxmr:xmr.mx> @thomasbuilds:matrix.org: Why? He's fixinf a non-issue

<thomasbuilds:matrix.org> he doesn't get it

<ofrnxmr:xmr.mx> botched rebase too

<ofrnxmr:xmr.mx> Re-added variables that arent used anymore

<ofrnxmr:xmr.mx> One of which causes his runawayspans issue

<ofrnxmr:xmr.mx> (*thomas licking his lips at dead code)

<thomasbuilds:matrix.org> lmao

<jeffro256> May I review beg on monero-project/monero #10934?

thomasbuilds opened pull request #10991: cryptonote_core: remove dead code

> monero-project/monero #10991

10934 is huge, I would review it but I don't have time today

plowsof opened issue #10992: wallet2_api: `doInit()` discards `use_ssl` (onions still attempt TLS h...

> monero-project/monero #10992

thomasbuilds opened pull request #10993: wallet2_api: skip the TLS handshake on Tor/I2P daemons

> monero-project/monero #10993

<borderless_dev15:matrix.org> Looking for US junior developers to join our team! Fully remote position with room for professional growth and solid income potential. Interested? Feel free to shoot me a DM or connect with me on Linkedin: linkedin.com/in/brando-martinez-b23833b7!

<rbrunner7> Well, how about solid income instead of merely solid income potential :)

<hbs:matrix.org> @rbrunner7: That's a potentiality

<jpk68:matrix.org> I got some insane review comments yesterday > <@thomasbuilds:matrix.org> his LLM is so bad he didn't realize he's fixing a closed issue lmao

<jpk68:matrix.org> monero-project/monero #10976#pullrequestreview-4792381477

<jpk68:matrix.org> monero-project/monero #10984#pullrequestreview-4792381594

.merge+ 10951 10952 10950 10949

Added

.merges

10747 10876 10949 10950

.merge+ 10459

Added

typo? 10459 is already merged

<jpk68:matrix.org> I think he meant 10458

.merge+ 10458

Added

<jpk68:matrix.org> ^ Has two approvals now, just FYI

jpk68 opened pull request #10994: chore: consolidate anonymity networks info

> monero-project/monero #10994

jeffro256 opened pull request #10995: wallet: upstream misc stuff before FCMP++

> monero-project/monero #10995

<jeffro256> ^ this PR is a fairly simply review, and gets some churn out of the way before the Carrot/FCMP++ integration reviews

<jeffro256> *fairly simple