-
br-m
<thomasbuilds:matrix.org> can I do
-
br-m
<thomasbuilds:matrix.org> .merge- 10605
-
br-m
<thomasbuilds:matrix.org> because he force pushed so needs approvals again
-
br-m
<thomasbuilds:matrix.org> all right makes sense that only maintainers can use these commands
-
br-m
<thomasbuilds:matrix.org> I did see though that someone did . merges and it worked
-
br-m
<thomasbuilds:matrix.org> .merges
-
br-m
<ofrnxmr:xmr.mx>
github.com/monero-project/monero/co…e0275a3c67fec89b076e8160d21eeec4ec2 > <@thomasbuilds:matrix.org> because he force pushed so needs approvals again
-
br-m
<thomasbuilds:matrix.org> he squashed commits?
-
br-m
<thomasbuilds:matrix.org> how do you know the old commit hash since it doesn't appear on github?
-
br-m
<ofrnxmr:xmr.mx> It does appear on gh
-
br-m
-
br-m
<thomasbuilds:matrix.org> my bad
-
br-m
<jeffro256> Sorry, I did that just a couple minutes after pushing. But yeah you can either A) hit the compare button on Github, or B) Use git diff
-
br-m
<jeffro256> Diff is empty
-
tobtoht
.merges
-
xmr-pr
10605 10886 10887 10964 11054 11121 11122 11123
-
tobtoht
GitHub's API doesn't mark approvals as stale if the diff is empty, so re-approving after a commit message was updated isn't strictly necessary.
-
br-m
<ofrnxmr:xmr.mx> Also, please never try to modify the merge queue. you can let selsta know if you have things you want removed. ^ > <@thomasbuilds:matrix.org> .merge- 10605
-
br-m
<ofrnxmr:xmr.mx> well intended, but its a stones throw from malicious
-
br-m
<thomasbuilds:matrix.org> let's say it was to test xmr-pr bot
-
br-m
<thomasbuilds:matrix.org> I expected it wouldn't react, it didn't right?
-
br-m
<ofrnxmr:xmr.mx> It didnt because you didnt use it properly
-
br-m
<thomasbuilds:matrix.org> xmr-pr: it's weird though because it replies to my . merges 20+ min later ??
-
br-m
<ofrnxmr:xmr.mx> it replied to tobtohts
-
br-m
<ofrnxmr:xmr.mx> matrix is stupid and lists the messages in the wrong order
-
br-m
<ofrnxmr:xmr.mx> also, that would be 2h20min later if it responded to yours
-
br-m
<thomasbuilds:matrix.org> so it isn't username restricted?
-
br-m
<thomasbuilds:matrix.org> like a malicious actor can change merge queue?
-
br-m
<thomasbuilds:matrix.org> @ofrnxmr:xmr.mx: so it is username restricted?
-
br-m
<ofrnxmr:xmr.mx> something like that
-
DataHoarder
the bot is on IRC, so it'd need to be someone or a puppet on irc side to produce the commands natively
-
selsta
it only works for voiced irc users
-
selsta
.merge+ 11170
-
xmr-pr
Added
-
br-m
<jpk68:matrix.org> Can #11054 be added, please?
-
tobtoht
it's queued
-
br-m
<jpk68:matrix.org> Whoops, my bad