<entropyhoover:matrix.org> For a small commit(around 100-200 lines diff), is it recommended to squash before pr, or squash only after pr is reviewed by someone?

Squash if you haven't submitted yet

<entropyhoover:matrix.org> I am curious why does the monero official wallet did not directly integrate the atomic swap? Is there any regulatory risk of doing this?

From afar, it looks like it doesn't belong. Same as the linux kernel doesn't include a text editor.

It can be pretty useful, but it's just not what the kernel is.

Monero also doesn't include a marketplace, exchange, etc, for the same reasons.

Someone else may build those, and there'll be choice (and, probably, danger).

Then again, monero does support a couple hardware wallets with code that doesn't really feel like it belong.

<entropyhoover:matrix.org> Feels like currently one the biggest problem for monero is scattered liquidity, it seems really difficult for new people(especially not tech savvy people) to figure out "how to reliably get monero".

It also depends on how feasible it is to build something else that does what you want (here, atomic swaps) without needing changes to monero software.

<maxxor:nitro.chat> @entropyhoover:matrix.org: there's sites like kycnot.me/?currency-mode=or¤cies=xmr

Yes, the issue is also one of looking at things differently. We're hackers (in the original meaning), and people using monero are often not.

<entropyhoover:matrix.org> I am thinking probably having an extension section in wallet that can optionally deploy those atomic swap in one click

<entropyhoover:matrix.org> In this way it doesn't clutter the main wallet

<maxxor:nitro.chat> a plugin system for the wallet? like it's implemented in electrum

Plugins would be great. They also require a very clean and stable/versioned API, so a pretty mature architecture.

And a lot of grunt work.

<ofrnxmr:xmr.mx> also, regarding atomic swaps, who's implementation do you choose? they require third party services. regarding hardware wallets, jus yesterday tobtoht pushed for removing them from the core repo

<ofrnxmr:xmr.mx> "I don't think we should allow third party hardware integrations in the main repo. We can set up a generic USB interface, and if a vendor wants to offer Monero support they can go ahead and implement that. We have given Trezor/Ledger way too much leverage over our code and dependencies."

<ofrnxmr:xmr.mx> and regarding plugins, even feather wallet rejected an atomic swap plugin, and is moving towards removing 3rd party stuff from the wallet

For trezor/ledger, I think two large parts for why they went in was "it seems very desirable to have" and "someone else is willing to do the work".

<ofrnxmr:xmr.mx> you need a bitcoin etc wallet integrated with the GUI to add atomic swaps, and third party networking -- the scripting is done via messaging and on the bitcoin network. id say these reasons along are enough to disauqlify any idea of integrating them into a monero core wallet

<ofrnxmr:xmr.mx> yeah, but now trezor is vibe coding 10000 lines of slop for their claude created interface

That seems like self sabotage for something with the overarching goal is security.

<ofrnxmr:xmr.mx> the number one commiter is claude

<ofrnxmr:xmr.mx> github.com/trezor/trezor-suite/graphs/contributors?from=5%2F23%2F2026

<ofrnxmr:xmr.mx> trezor/trezor-suite #29235 slop

<entropyhoover:matrix.org> > <@ofrnxmr:xmr.mx> also, regarding atomic swaps, who's implementation do you choose? they require third party services. regarding hardware wallets, jus yesterday tobtoht pushed for removing them from the core repo

<entropyhoover:matrix.org> My thought are not really polluting the wallet by directly put their code in, but mostly get a separate menu, list out the mature implementations along some introduction, and a simple script to download and verify the bin, and can directly start the binary in that menu. So someone want an atomic swap can directly look at this [... too long, see mrelay.p2pool.observer/e/k6vz2qULWFR1czg0 ]

<ofrnxmr:xmr.mx> i widely disagree

<ofrnxmr:xmr.mx> atomic swap platforms require wallets. eigenwallet and basicswap, for example, include monero wallets. they dont need to be in gui.

<ofrnxmr:xmr.mx> and bitcoin definitely doesnt need to be in gui.

<thomasbuilds:matrix.org> tevador / SChernykh for randomX, is src/aes_hash_rv64_zvkned.cpp meant to require the Zvkned intrinsics on every riscv64 build, even when the capability probes report the extension absent? It doesn't build with Ubuntu's riscv64 gcc 13.3.0.

<ofrnxmr:xmr.mx> thats sect1 *

<ofrnxmr:xmr.mx> sech1 ***

It requires gcc 14, I think? Or gcc 15

whichever supports zvkned properly

"RandomX bump requires GCC 14 bump on RISC-V platforms."

<thomasbuilds:matrix.org> README still says gcc 4.8+/7+ and lists RISCV64 as validated

<ofrnxmr:xmr.mx> why would it say otherwise

<ofrnxmr:xmr.mx> randomx v2 isnt shipped?

<ofrnxmr:xmr.mx> are you building v1.x?

<thomasbuilds:matrix.org> master not v1.x, my bad on the README

is there a darkmode version of this chat?

that is totally up to you and your client

it's IRC, you can join it using any IRC client you prefer

any new updates on monero dev?