-
xmr-prmj-xmr opened pull request #3858: CMake: clearer sep. between the library and executable code
-
xmr-pr
-
mj-xmr[m]Re: #3858 I'm trying to bring some structure there, because I'd like to have it easier to quickly check the new features visually.
-
mj-xmr[m]and for other reasons, like testability.
-
selstamj-xmr[m]: I'm fine with adding structure, but what do you mean with "easier to quickly check the new features visually" ?
-
mj-xmr[m]selsta: it means, that it's a prelude of my further reviews. I'd like to be able to quickly checkout a given branch and compile + run. Without working linking this takes some space. In the current situation I have to rely on you approving the feature, while I can only check if it looks technically good from the code alone. I hope it explains it.
-
mj-xmr[m]*without a working dynamic linking.
-
selstahmm I don't follow
-
selstawhat happens when you checkout a branch now?
-
mj-xmr[m]selsta: I can't link dynamically, because the installed (in `bin`) monero-wallet-qt can't find any dynamic libraries, while all the core executables can.
-
selstaok and just doing `make` is too slow?
-
mj-xmr[m]Let's say that it could be somehow faster. But the fact that the whole project behaves differently than Core, even if I try to force it, sounds like there may be more bugs to uncover. And this can be done only after enforcing some structure.
-
mj-xmr[m]*done = uncovered.