luigi1111w: don't forget about merge and tag before you go to sleep

luigi1112: ^

constantly changing name lol complicated

luigi1111 and the rare luigi1113

Gotta catch em all

Hey is there any immediate plans for RPC over SSL for the GUI wallet?

jeffro256[m]: it should use SSL by default

did you test it?

rpc-ssl is kinda buggy without monero-project/monero #7760 but that's a different topic

no I just grep'd SSL in the codebase

lol

I meant more like is there any plans for more fine-grained control over the SSL ?

Like is it an active thing currently?

jeffro256[m]: GUI uses wallet2 code

so it should work the same way as the CLI wallet by default

(it will use SSL if the node supports it)

but there is no fine grained control currently

Yeah I figured it used transparent SSL if available, but there really isn't a way to enforce which SSL keys it uses correct?

Like with the CLI

yes

Thanks! Sorry for the dumb questions

it shouldn't be difficult to add but the UI for it might be annoying

I think it could be beneficial to have some kind of connection security indicator like most browsers have

Maybe a little lock that is red if RPC is over plaintext, yellow if using whatever SSL is given, green if using explicit SSL

I need to look more into how wallet2 handles it

luigi1111: hmm, can you force push the tag?

the merges are missing

.merges

oh

try again

looks good now

luigi1112: monero-project/monero-gui #3897

there is still a malicious node going around that sets high fees, so I would like to include this in the release (sorry lol)

another force push?

what do you think, should we force push the tag again, or tag v0.17.3.3?

the gui barely has devs anyway

I like force pushing

sounds good

keeps 'em guessing

can someone review this?

if tx fee is > 0.01, it will increase the size, change color and add "HIGH!!!"

ez

mj-xmr[m]: are you here?

can you review 3897 (code logic)

or jeffro256[m] maybe ^

<luigi1112> "can someone review this?" <- im compiling now

code looks good, > check for 0.01 and change pixel size to 20

reeemuru[m]: you have to set it to 0.001 or so for testing

one sec

otherwise it doesn't trigger for a normal tx with highest fees

the next step will be replace simple mode with a list of trusted nodes, but that won't be ready for this release

Looks good logically! I'll compile it soon. As a matter of code clarity, I would put a name to the constants 0.01, like maximumNormalFee, so its not so magic

donzo

looks good

i sent the payment anyways though🫣

jeffro256[m]: I agree generally with no magic numbers but in this case it doesn't seem too important

it's basically all one bool

luigi1112: it's approved now

ty for the quick review reeemuru[m] jeffro256[m]

it's not a review it's a comment

er

it's not a thumbsup

pls

I'm a simple man

done

wait thats the approve thing right, sorry no coffee today

<selsta> "mj-xmr: are you here?" <- Hey. Still here. Will check

mj-xmr[m]: it's approved already :) but thanks!

ah :)

I've never actually compiled Qt all the way from scrath before

It takes ages

jeffro256[m]: what OS do you use?

Plain old ubuntu

do you use docker to compile?

I used to do that but I'm trying to compile it natively for the heck of it (and without using the installer where you have to put in your email)

The open source repo is like 7GB

this installer doesn't require an email but it's 5.12 instead of 5.15

but native compiling works too :P

Is that like a Linux AppImage installer script?

it's some kind of script

don't know details

There's so many ways to install it lol

apt works too

for some reason, apt didn't work for me because it didn't install the Qt5QuickConfig.cmake file

which Ubuntu version?

20.04.4

hmm weird that should work fine

we use that version for CI

Specifically which package do you use?

check .github/workflows/ci.yaml or so

then there is one for ubuntu with all the steps

cool ill take a look

Do you mean build.yaml?

yes

Ah I was missing qtdeclarative5-dev even though I had qtbase5-dev b/c of some other unrelated dependency issue. I'm still gonna try to compile qt just for fun though