-
gingeropolous
perhaps the GUI should include a dialogue on first startup regarding storing the blockchain in a custom location
-
BigmenPixel[m]
-
BigmenPixel[m]
s/an/a/, s/error/mistake/
-
selsta
this will set the release date to when we touched the cmakelists / last git commit, this can be up to a week earlier than the actual release date
-
selsta
setting it to when CI is running would make more sense to me
-
BigmenPixel[m]
selsta: But there is also another method with git.
-
BigmenPixel[m]
Something wrong in it?
-
BigmenPixel[m]
Oops, I understand now.
-
selsta
yes, it won't match with the actual release date since time between last tag and the actual release date can differ by up to a week
-
BigmenPixel[m]
selsta: So is it possible to use `date` command there?
-
selsta
-
selsta
I would do it similarly to this
-
selsta
Add a `<dstamp>` placeholder
-
selsta
and then run `sed -rf s/<dstamp>/$(date '+%Y%m%d')/g` from CI
-
BigmenPixel[m]
And what about $(date '+%Y-%m-%d')?
-
BigmenPixel[m]
I don't fully understand how should it work. Get the current date (when CI is working) or timestamp of some file?
-
BigmenPixel[m]
<selsta> "Add a `<dstamp>` placeholder" <- Where?
-
selsta
-
selsta
inside the date thing
-
selsta
then you run the sed command so that it replaces <dstamp> with the real date
-
selsta
this is assuming you want to only show the latest version
-
BigmenPixel[m]
<selsta> "then you run the sed command..." <- That looks good, without env.
-
selsta
the command i posted was only an example, you will have to adapt it
-
BigmenPixel[m]
<selsta> "the command i posted was only an..." <- This works:... (full message at <
libera.ems.host/_matrix/media/v3/do…da7ea8b0c8098a555906b5d81f1af1cebfd>)
-
selsta
I meant without CMake at all
-
BigmenPixel[m]
So now it's need to select a "trigger" for cmake subdirectory. Is existing of #FLATPAK_ID good?
-
BigmenPixel[m]
selsta: Sorry, I needed to say it.
-
BigmenPixel[m]
s/#FLATPAK_ID/$FLATPAK\_ID/
-
selsta
-
BigmenPixel[m]
selsta: Also it will need to get the version there.
-
BigmenPixel[m]
* it will be need to
-
selsta
${{ github.event.release.tag_name }}
-
selsta
can also be done from github actions without CMake
-
BigmenPixel[m]
selsta: Good, I will do so.
-
selsta
so after each `uses: actions/checkout@v3` I would run 2 sed commands, one that replaces with the current date and one that adds `${{ github.event.release.tag_name }}`
-
selsta
you have a version placeholder and a date placeholder
-
BigmenPixel[m]
<selsta> "you have a version placeholder..." <- ```... (full message at <
libera.ems.host/_matrix/media/v3/do…8e1a2fc9c2e84769c6bb580a214c54729b5>)
-
BigmenPixel[m]
Oops, wait.
-
selsta
the version is wrong
-
selsta
sed -i 's/<version>/${{ github.event.release.tag_name }}/g' file
-
BigmenPixel[m]
selsta: ```
-
BigmenPixel[m]
sed -i 's/<version>/'"${{ github.event.release.tag_name }}"'/g'
-
BigmenPixel[m]
```
-
BigmenPixel[m]
- name: Add version and date
-
BigmenPixel[m]
run: |
-
BigmenPixel[m]
sed -i 's/<version>/${{ github.event.release.tag_name }}/g' monero-gui/flatpak/org.getmonero.Monero.metainfo.xml
-
BigmenPixel[m]
sed -i 's/<date>/'"$(date '+%F')"'/g' monero-gui/flatpak/org.getmonero.Monero.metainfo.xml
-
BigmenPixel[m]
flatpak directory won't be.
-
BigmenPixel[m]
* flatpak directory won't be in the final.
-
selsta
looks good assuming the path is correct
-
selsta
and you have to add this after each checkout
-
BigmenPixel[m]
<selsta> "and you have to add this after..." <- Maybe only after the latest?
-
BigmenPixel[m]
Prt 3
-
BigmenPixel[m]
* Part 3
-
selsta
I don't know when it uses these .xml files
-
BigmenPixel[m]
Because the appdata will install there.
-
selsta
then adding it in part3 should be enough
-
BigmenPixel[m]
selsta: Ok.
-
BigmenPixel[m]
So are there any problems also? I will need to add checkers and everything is fine..?
-
selsta
can you clarify? problems where?
-
BigmenPixel[m]
selsta: Problems to push
-
selsta
you can update the PR
-
BigmenPixel[m]
selsta: Well, I will update when it works. I'm now at the `flatpak` branch for testing.