we had issues with freetype git repo being offline, i noticed Dockerfile.windows uses --qt-freetype doc.qt.io/qt-5/configure-options.html#third-party-libraries , uses freetype bundled within qt whereas the Linux dockerfile clones a freetype git repo instead hm

-opengl desktop for linux and -opengl dynamic in windows docker (dynamic seems the sane option doc.qt.io/qt-5/windows-requirements…ynamically-loading-graphics-drivers)

this stuff was setup by xiphon ages ago

tobtoht_: github.com/monero-project/monero-gu…14146373464/job/39634172034?pr=4426

is the compiler too old for this syntax?

<t​zadiko:matrix.org> That's structured bindings introduced in C++17

<t​zadiko:matrix.org> Builds fine on Monero. Is the compiler the Monero-GUI uses different?

we use C++ 14 in release branch from what i remember

though i'm confused why this passed CI

<t​zadiko:matrix.org> Why can't we upgrade the compiler the Monero-GUI uses to use the same one used in Monero project? Is there a reason not to?

it's not about the compiler, we have C++17 code in a C++14 project github.com/monero-project/monero/bl…ob/release-v0.18/CMakeLists.txt#L99

<t​obtoht:monero.social> also thoroughly confused how this passed ci

<t​zadiko:matrix.org> Where is the build code located for the pipeline located?

<t​zadiko:matrix.org> Is it the Dockerfile?

<t​zadiko:matrix.org> Oh it's probably not, NVM

<t​obtoht:monero.social> github.com/monero-project/monero-gui/blob/master/Dockerfile.linux

<t​obtoht:monero.social> Uses Ubuntu 16.04 base image with gcc 5, which is ancient

<t​obtoht:monero.social> we could try bumping it to 18.04 and see how much stuff breaks

<t​zadiko:matrix.org> LOL, yeah I see the build-Ubuntu builds with GNU 13 and the build-docker-linux does with GNU 5.4

i will try updating the base imagfe

image

<t​obtoht:monero.social> i was able to build with 18.04

<t​obtoht:monero.social> 4c54ea41ca869e89fb5e944f0e3f5243ed27d1e1963ab9d7ca3c4594c01cdc76 monero-wallet-gui

<t​obtoht:monero.social> forgot to run git submodule update

<t​obtoht:monero.social> f621c7d8005e257c9ee099311bd965740b4be99b55458a0147858dbb8c4c44f1 monero-wallet-gui

alternatively we could apply a patch in the dockerfile but also 16.04 is ancient

tobtoht_: monero-project/monero-gui #4428

<t​obtoht:monero.social> hashes from ci match my local build (github.com/tobtoht/monero-gui/actions/runs/14147236386)

<t​obtoht:monero.social> approved

<t​obtoht:monero.social> i think patching will get messy since it uses the bind-mounted monero submodule

.merge+ 4426 4427 4428

Added

now i have to find out why this suddenly fails github.com/selsta/monero-gui/action…47258151/job/39636066260#step:7:125

<t​obtoht:monero.social> not critical for release since you build gui locally right?

<t​obtoht:monero.social> on macos i mean

yes not critical

<t​zadiko:matrix.org> Curious how you knew you needed libpng instead of libpng12

libpng12 did not exist and libpng was the next closest thing

i guessed the same lol