<j​pk68:matrix.org> Would someone mind submitting this to #4573?

<j​pk68:matrix.org> paste.debian.net/plainh/b68d7733

<j​pk68:matrix.org> Another small one: paste.debian.net/plainh/d4d596d7

<j​pk68:matrix.org> selsta: Sorry for the ping, I was just wondering if you would be willing

<j​pk68:matrix.org> or someone else you know of :)

it would probably be best if someone takes over the whole PR since the person in 4573 doesn't want to continue anymore

<j​pk68:matrix.org> I would, but unfortunately GitHub kind of hates me

<j​pk68:matrix.org> and my account is still (falsely) suspended

did you mean with submitting adding a comment with the patch links, or pasting the patches itself into a comment?

<j​pk68:matrix.org> Anything works

<j​pk68:matrix.org> The CI stuff is kind of beyond me, but I think I can make some decent progress on the rest of the PR

CI stuff is just getting it to build on all OS

<j​pk68:matrix.org> Yes, I know, I'm just not sure I'm super qualified to fix that

added a comment

<j​pk68:matrix.org> Thanks :)

selsta if you want i can take over

whatsayjose1980-: I misread the comment in 4573, seems they are still working on it just not interested in fixing CI at the moment

<j​pk68:matrix.org> w​hatsayjose1980-: Are you the guy that submitted this PR yesterday?

<j​pk68:matrix.org> monero-project/monero #10370

yes

<j​pk68:matrix.org> Interesting...

selsta ok

m-relay_ interesting as in?

<j​pk68:matrix.org> Uhh, it was an interesting PR

m-relay_ as in?

i am working on something for a private vested group

large swathes of conversion

without the essence mbweb yet private

ok

@plowof sorry for bothering you yesterday mate

it was the highlight of my week, thank you

plowsof :)

but i didnt change anything tbh

they were as they were

thanks mate

logging out now

nice to talk to you, have a wonderful evening

mine is half past night

cheers mate enjoy tthe eve, night is young for you

<j​pk68:matrix.org> A few more fixes: paste.debian.net/plainh/e6f39911

<o​frnxmr:xmr.mx> Shared

<j​pk68:matrix.org> There may be more coming ;)

<o​frnxmr:xmr.mx> Finish and sell all at once?

<j​pk68:matrix.org> Maybe, I guess

<j​pk68:matrix.org> The problem is, if two people are working on it, the other person might do work I already finished

<j​pk68:matrix.org> or vice versa

<o​frnxmr:xmr.mx> I doubt the pr is going to be merged eith its 50+ commits not squashed

<o​frnxmr:xmr.mx> So fix conflicts :P

<j​pk68:matrix.org> Fair point, but still, it would waste time

<j​pk68:matrix.org> This should have been done, like, yesterday

<o​frnxmr:xmr.mx> The pr or the migration to qt6?

<j​pk68:matrix.org> Qt6 migration. I don't mean to point fingers or anything

<j​pk68:matrix.org> Qt5 was deprecated like a year ago

<o​frnxmr:xmr.mx> I dont know anything about qt but is this pr even the right way to go about it?

<o​frnxmr:xmr.mx> Seems rather messy

<o​frnxmr:xmr.mx> Youd think this can be done a lot cleaner(?)

<j​pk68:matrix.org> How else would you do it? The new Qt version is full of a huge number of breaking changes

<j​pk68:matrix.org> How so?

<o​frnxmr:xmr.mx> ^

<o​frnxmr:xmr.mx> Twas a question

<j​pk68:matrix.org> My bad :)

<o​frnxmr:xmr.mx> I just see 144 files changes and think "this aint getting reviewed "

Make feather wallet look like the gui? :P

<o​frnxmr:xmr.mx> And i see stuff like this and wonder "tf?"

<o​frnxmr:xmr.mx> ```

<o​frnxmr:xmr.mx> run: DEV_MODE=ON make release -j3

<o​frnxmr:xmr.mx> run: DEV_MODE=ON make release -j"$(sysctl -n hw.ncpu)"

<o​frnxmr:xmr.mx> ```

<o​frnxmr:xmr.mx> A few lines lower

<o​frnxmr:xmr.mx> ```

<o​frnxmr:xmr.mx> run: DEV_MODE=ON make release -j3

<o​frnxmr:xmr.mx> run: y make release -j"$(nproc)"

<o​frnxmr:xmr.mx> ```

<o​frnxmr:xmr.mx> Like why inconsist

<o​frnxmr:xmr.mx> Ent

<j​pk68:matrix.org> Yeah, not sure

<o​frnxmr:xmr.mx> And `run: y make release -j"$(nproc)"` is a typo?

<j​pk68:matrix.org> matrix.monero.social/_matrix/media/…matrix.org/zUlMvHQzzcUfgjCIfXprPKGO

<j​pk68:matrix.org> Left is Qt6, right is current release

<j​pk68:matrix.org> Still some work to do with shadows and stuff

<j​pk68:matrix.org> and the whole balance card thing is just not there (?)

<o​frnxmr:xmr.mx> #startfresh

<j​pk68:matrix.org> We might be in for a slight unintentional redesign :)

<o​frnxmr:xmr.mx> The CI changes dont seem to all be coherent

<j​pk68:matrix.org> OP did say that they couldn't really fix it

<j​pk68:matrix.org> monero-project/monero-gui #4573#issuecomment-4081857258

<o​frnxmr:xmr.mx> So i guess my question is mainly, is the rest of the pr somethimg we shoukd be buikding off of?

<o​frnxmr:xmr.mx> The ci isnt juat annoying to fix, it looks like it was broken

<o​frnxmr:xmr.mx> Revert all changes to it, and do it properly :D

<j​pk68:matrix.org> I guess I can always rebase to my fork on Codeberg, and then submit from there or something

<o​frnxmr:xmr.mx> A couple sane changes a bunch lf random unnecessary ones dont inspire confidence for the rest of the pr

<o​frnxmr:xmr.mx> Its easy for ie me to clobe for codeberg fork and pish the branch to my github

<j​pk68:matrix.org> Might be rude to take credit for it though, since I will have done maybe 10 out of the 54 commits

<j​pk68:matrix.org> Thanks :)

Still(wondering): what llm does those commit titles

OP said they cant be bothered to fix it right now, but their git is hidden so i cant see their work

<j​pk68:matrix.org> plowsof: Not everything is vibecoded... maybe some of us are just NPCs :)

<j​pk68:matrix.org> ofrnxmr Got another one for you

<j​pk68:matrix.org> paste.debian.net/plainh/858d7974

I would ideally like Qt 5 and 6 support simultaneously but not sure if that's possible