EntropyHoover opened issue #4686: Dead code in DaemonManager::start

> monero-project/monero-gui #4686

<entropyhoover:matrix.org> Also this piece of code seems redundant #ifndef Q_OS_WIN

<entropyhoover:matrix.org> arguments << "--detach";

<entropyhoover:matrix.org> #endif

<entropyhoover:matrix.org> If we are already doing bool started = m_daemon->startDetached(m_monerod, arguments);

<entropyhoover:matrix.org> in daemonManager.cpp?

<ofrnxmr> @entropyhoover:matrix.org: monero-project/monero-gui #4581

<entropyhoover:matrix.org> Seems closed due to qt 6 migration? So the issue right now is waiting for the migration rewrite?

<ofrnxmr> I think so

<thomasbuilds:matrix.org> yeah

<entropyhoover:matrix.org> So if I write code about this issue, should I create a separate pr or put in this monero-project/monero-gui #4659?

<ofrnxmr> you can build on top of 4659, or you can wait

<ofrnxmr> Id just say try not to write something that will be invalidated shortly

.merges

4681 4682

<jpk68:matrix.org> #4592 has an approval

done

<jpk68:matrix.org> #4685 and #4680 may be good as well

<jpk68:matrix.org> #4679 needs another look

selsta opened pull request #4687: Sign: show signed message key type

> monero-project/monero-gui #4687

.merge+ 4679

Added

.merge+ 4688

Added

.merge+ 11199

Added

.merge- 11199

Removed

.merges

4679 4688

done