-
selstayea, that definitely doesn't look correct
-
selstasome are .po and some are .pot
-
selstabut just `.` looks wrong
-
QuickBASICYeah it's broken my workflow because git can't sync it to NTFS and so git thinks they're deleted and I can't unstage the change because they don't exist.
-
QuickBASICIf I just reset hard on the commit before it I can actually use git again. Will that break anything later when I PR?
-
ErCiccioneyeah i must have commit them by mistake. I'm gonna remove them
-
ErCiccioneQuickBASIC: you can base your PR on monero-project/monero-site #1859
-
ErCiccione<ErCiccione> "luigi1111 please merge 1835" <- actually hold on. We might need to edit a couple more things
-
ErCiccione^ disregard. I misunderstood. Can be merged
-
QuickBASICErCiccione sorry to be a bother, but the reason all three moneropedia entries were submitted as a single commit was because I wanted to include links referencing each entry in the others. Maybe I'm daft, but how would I make three separate commits?
-
QuickBASICAdd one entry without links to other, commit, add entry without links to other, commit, add entry with links and edit other entries to add links, commit? Seems messy if I'm going to have to refactor the grammar during review.
-
QuickBASICMy git-fu is like toddler level.
-
selstashould be fine to keep it as one commit IMO
-
QuickBASICYeah selsta, Its fine either way, I'm just asking for clarification on his review comment.
-
QuickBASICReviewed 1859. This makes it really difficult for Windows contributors to base their work on the most updated version of the site. (See my comment for explanation of why this is monero-project/monero-site #1859#pullrequestreview-769602221) Is there any reason that this can't be merged relatively quickly?
-
selstaluigi1111: ^
-
luigi1111soon
-
QuickBASIC™