-
m-relay
<ofrnxmr:xmr.mx> What is this
-
m-relay
<pyxmr2025:mozilla.org> plowsof and your noreply email's header.
-
m-relay
-
m-relay
<pyxmr2025:mozilla.org> Thank you very much!plowsof and ofrnxmr.I learnt a lot!
-
m-relay
<pyxmr2025:mozilla.org> @plowsof:matrix.org @ofrnxmr:xmr.mx That's the title, i18n: Fix fcmp keys and update documentation
-
m-relay
<pyxmr2025:mozilla.org> - Added hyphens to fcmp keys
-
m-relay
<pyxmr2025:mozilla.org> - Removed duplicate translation keys
-
m-relay
<pyxmr2025:mozilla.org> - Corrected FAQ and roadmap entries
-
m-relay
<pyxmr2025:mozilla.org> Co-authored-by: nahuhh <50635951+ nahuhh⊙ungc >
-
m-relay
<pyxmr2025:mozilla.org> Co-authored-by: plowsof <77655812+ plowsof⊙ungc >
-
m-relay
<ofrnxmr:xmr.mx> No
-
m-relay
<ofrnxmr:xmr.mx> Wtf bro
-
m-relay
<ofrnxmr:xmr.mx> Remove the co-authors!
-
plowsof
i can resubmit to stop the spam
-
m-relay
<ofrnxmr:xmr.mx> The pr was correct a few hrs ago. Idk why Jackie @pyxmr2025:mozilla.org does not listen
-
m-relay
<ofrnxmr:xmr.mx> I specifically said "dont add co-authors to this"
-
m-relay
<pyxmr2025:mozilla.org> OK,wait.
-
m-relay
<pyxmr2025:mozilla.org> OK,wait for an hour.
-
m-relay
<pyxmr2025:mozilla.org> sorry.
-
plowsof
🙏
-
m-relay
<pyxmr2025:mozilla.org> I closed my PR and merged it directly
monero-project/monero-site #2487 Okay.
-
plowsof
thank you
-
m-relay
<pyxmr2025:mozilla.org> Well, I'm an impatient person. I will change my habit of sending spam. I'm really sorry to disturb you.
-
plowsof
.merge- 2486
-
xmr-pr
Removed
-
plowsof
.merge+ 2487
-
xmr-pr
Added
-
m-relay
<pyxmr2025:mozilla.org> Well, I'm an impatient person. I will change my habit of sending spam. I'm really sorry to disturb you and ofrnxmr.
-
m-relay
-
m-relay
<ofrnxmr:xmr.mx> Stop
-
m-relay
<pyxmr2025:mozilla.org> ok,del
-
m-relay
<pyxmr2025:mozilla.org> sorry
-
m-relay
<pyxmr2025:mozilla.org> I have a question: Since it's already done, why hasn't it been merged yet?
-
m-relay
<ofrnxmr:xmr.mx> because you're nagging and spamming our email
-
m-relay
<pyxmr2025:mozilla.org> Okay, I'll stop talking.
-
m-relay
<pyxmr2025:mozilla.org> I won't care about this
-
m-relay
<ofrnxmr:xmr.mx> i didnt say stop talking, i'm saying stop asking every 60mins "when merge"
-
m-relay
<pyxmr2025:mozilla.org> well.Okay.
-
m-relay
<ofrnxmr:xmr.mx> the work is done, it will be merged shortly
-
m-relay
<pyxmr2025:mozilla.org> good Thank you, I will not continue to inquire.
-
m-relay
<ofrnxmr:xmr.mx> thank you. be patient
-
m-relay
<ofrnxmr:xmr.mx> shouldnt be long, its not a big change
-
m-relay
<ofrnxmr:xmr.mx> Merging when someone is pressuring you to merge, is a bad precedent to set. So just kick back and relax / continue work on the other pr
-
m-relay
<pyxmr2025:mozilla.org> Thank you for teaching.
-
m-relay
<pyxmr2025:mozilla.org> merged
-
m-relay
<ofrnxmr:xmr.mx> delete your merge commit
-
m-relay
<ofrnxmr:xmr.mx> We don't do merge commits in PRs
-
m-relay
<ofrnxmr:xmr.mx> `git reset --hard HEAD~1`
-
m-relay
<ofrnxmr:xmr.mx> then force push
-
m-relay
<ofrnxmr:xmr.mx> if you have any uncommited work, it will be lost. Run `git stash` first if you have uncommitted work
-
m-relay
<ofrnxmr:xmr.mx> Jackie @pyxmr2025:mozilla.org
-
m-relay
<pyxmr2025:mozilla.org> What do you mean, which PR
-
m-relay
-
m-relay
<ofrnxmr:xmr.mx> if you didnt do the merge commit manually, then your IDE did it and you need to disable some setting
-
m-relay
<pyxmr2025:mozilla.org> OK,wait.
-
m-relay
<pyxmr2025:mozilla.org> Do I create a PR after completing my work?
-
m-relay
<ofrnxmr:xmr.mx> what?
-
m-relay
<pyxmr2025:mozilla.org> This is a translation PR
-
m-relay
<ofrnxmr:xmr.mx> in the translation pr, there is a merge commit here
monero-project/monero-site ecdba51
-
m-relay
<ofrnxmr:xmr.mx> This should not be here
-
m-relay
<pyxmr2025:mozilla.org> uh,yes
-
m-relay
-
m-relay
<ofrnxmr:xmr.mx> if it isnt caused by your IDE, its possibly due to using master and pulling in the latest master
-
m-relay
<ofrnxmr:xmr.mx> Yes, just `git reset --hard HEAD~1`
-
m-relay
-
m-relay
<pyxmr2025:mozilla.org> This was generated when I synchronized the branch
-
m-relay
<ofrnxmr:xmr.mx> Oh, you did this using github. Even worse :D lol
-
m-relay
<pyxmr2025:mozilla.org> yes,github
-
m-relay
-
m-relay
<pyxmr2025:mozilla.org> Do I still need to delete it
-
m-relay
<ofrnxmr:xmr.mx> It messed up your pr becauae you created the pr using your master branch
-
m-relay
<ofrnxmr:xmr.mx> Yea, delete it
-
m-relay
<pyxmr2025:mozilla.org> Yes
-
m-relay
<ofrnxmr:xmr.mx> Use the terminal
-
m-relay
<pyxmr2025:mozilla.org> Shall I delete it first and then open a new one?
-
m-relay
<ofrnxmr:xmr.mx> use da terminal
-
m-relay
-
m-relay
<pyxmr2025:mozilla.org> ofrnxmr: hey.
-
m-relay
<pyxmr2025:mozilla.org> Deleted it, what should I do or not do
-
m-relay
<ofrnxmr:xmr.mx> How did you delete it
-
m-relay
-
m-relay
<ofrnxmr:xmr.mx> Ok, run `git remote -v`
-
m-relay
<pyxmr2025:mozilla.org> then?
-
m-relay
<ofrnxmr:xmr.mx> What does it output?
-
m-relay
-
m-relay
<ofrnxmr:xmr.mx> `git remote add upstream
github.com/monero-project/monero-site`
-
m-relay
<pyxmr2025:mozilla.org> then
-
m-relay
<ofrnxmr:xmr.mx> `git fetch upstream`
-
m-relay
<pyxmr2025:mozilla.org> root@61dd977e4482:/workspace/monero-site# git fetch upstream
-
m-relay
<pyxmr2025:mozilla.org> remote: Enumerating objects: 14, done.
-
m-relay
<pyxmr2025:mozilla.org> remote: Counting objects: 100% (8/8), done.
-
m-relay
<pyxmr2025:mozilla.org> remote: Compressing objects: 100% (3/3), done.
-
m-relay
<pyxmr2025:mozilla.org> remote: Total 14 (delta 5), reused 6 (delta 5), pack-reused 6 (from 2)
-
m-relay
<pyxmr2025:mozilla.org> Unpacking objects: 100% (14/14), done.
-
m-relay
-
m-relay
<pyxmr2025:mozilla.org> * [new branch] dependabot/bundler/rexml-3.3.3 -> upstream/dependabot/bundler/rexml-3.3.3
-
m-relay
<pyxmr2025:mozilla.org> * [new branch] master -> upstream/master
-
m-relay
<ofrnxmr:xmr.mx> `git rebase upstream/master`
-
m-relay
<pyxmr2025:mozilla.org> Applying: Translation on lines 1-46
-
m-relay
<pyxmr2025:mozilla.org> Applying: Fix errors on lines 1-46
-
m-relay
<pyxmr2025:mozilla.org> Applying: Translate lines 48-61 corresponding to en.yml
-
m-relay
<pyxmr2025:mozilla.org> Applying: Translate 63-120 lines and fix known errors
-
m-relay
<pyxmr2025:mozilla.org> Applying: Translate lines 122 to 143 in en.yml to zh-cn.yml
-
m-relay
<pyxmr2025:mozilla.org> Applying: Fix known details issues
-
m-relay
<pyxmr2025:mozilla.org> Applying: 128 line fix (IRC) for Chinese bracket issue
-
m-relay
<pyxmr2025:mozilla.org> Applying: Translated lines 145-245 (corresponding to en.yml) and fixed the issue with Chinese quotation marks.
-
m-relay
<pyxmr2025:mozilla.org> Applying: Translated lines 227-302 of en.yml and fixed quotation mark and colon issues
-
m-relay
<pyxmr2025:mozilla.org> Applying: Translated lines 384-589 of en.yml and improved the translation of 'Chat' to make it more colloquial
-
m-relay
<pyxmr2025:mozilla.org> Applying: Fixed 476 lines @mnemonic-seed
-
m-relay
<pyxmr2025:mozilla.org> git push -f origin <>?
-
m-relay
<pyxmr2025:mozilla.org> What does the branch write
-
m-relay
<pyxmr2025:mozilla.org> master?or
-
m-relay
-
m-relay
<pyxmr2025:mozilla.org> Thanks!
-
m-relay
<ofrnxmr:xmr.mx> Np
-
m-relay
<ofrnxmr:xmr.mx> You still need to edit the keys in the cn file
-
m-relay
<ofrnxmr:xmr.mx> want me to get nahuhh to send diff?
-
m-relay
<pyxmr2025:mozilla.org> No need, thank you. I will
-
m-relay
-
m-relay
<pyxmr2025:mozilla.org> I also changed the translation of the previous video_ring, which I think is more appropriate
-
m-relay
<pyxmr2025:mozilla.org> Thank you very much.