-
m-relay
<redsh4de:matrix.org> Yes, we can lazy load non-essential content like images or other kb-heavy files
-
m-relay
<redsh4de:matrix.org> That way the text loads first, and the eyecandy loads last
-
plowsof
.merge+ 2482
-
xmr-pr
Added
-
plowsof
.merge+ 2458
-
xmr-pr
Added
-
plowsof
-
plowsof
if yes then we can finally add it to the roadmap before its completed
monero-project/monero-site #2420
-
m-relay
<diego:cypherstack.com> There's generally positive chatter in the channel, yeah
-
plowsof
.merge+ 2420
-
xmr-pr
Added
-
m-relay
-
m-relay
<redsh4de:matrix.org> i18n friendly, to make new entries just have to make a new .md file in src/content/moneropedia/<locale>. the build process handles the rest
-
m-relay
<redsh4de:matrix.org> linking to other moneropedia entries is done with the `@` tag, same as in the current site
-
m-relay
<redsh4de:matrix.org> currently for a non-default locale if a moneropedia entry is not translated, it will not show up in the index page. lmk how everything looks overall
-
m-relay
<redsh4de:matrix.org> (this is the only entry to showcase the @ tags, everything else is lorem ipsumed out)
-
m-relay
<basses:matrix.org> how far is i18n for being "complete"?
-
m-relay
<redsh4de:matrix.org> more or less done, the biggest part is just adding the supported locales and translations in src/i18n/translatiosn
-
m-relay
<redsh4de:matrix.org> s/translatiosn/translations
-
m-relay
<basses:matrix.org> and RTL support?
-
m-relay
<redsh4de:matrix.org> not yet, gonna bake that in rn
-
m-relay
<basses:matrix.org> you what RTL is right? and I usally see people mess it up
-
m-relay
<redsh4de:matrix.org> Yh, for arabic languages
-
m-relay
<basses:matrix.org> I will give feedback so it have the best RTL support.
-
m-relay
<basses:matrix.org> yeah and other languages too like persian etc
-
plowsof
.merges
-
xmr-pr
2420 2458 2482 2546 2560 2562
-
m-relay
<redsh4de:matrix.org> Usually ppl severely overcomplicated
-
m-relay
<redsh4de:matrix.org> I have to extend the layout to support passing in the dir tag and define a list for which locales to apply it
-
m-relay
<redsh4de:matrix.org> s/overcomplicated/overcomplicate it
-
m-relay
<basses:matrix.org> also some icons need reversing
-
m-relay
<basses:matrix.org> like arrows etc
-
m-relay
<basses:matrix.org> they just set dir="rtl" and call it a day
-
m-relay
<redsh4de:matrix.org> for directional icons same thing - since im using a component for icons, can pass in a similar tag so that it flips the image on build time for locales that need it
-
m-relay
<redsh4de:matrix.org> also for dropdown menus that anchor from a specific point to avoid overflowing from the viewport
-
m-relay
<basses:matrix.org> here's the thing, the whole redesign was just for desktop and don't include pics of mobile concepts... Diego Salazar
-
m-relay
<basses:matrix.org> so it is hard to judge how mobile should look like
-
m-relay
<diego:cypherstack.com> This is true.
-
m-relay
-
m-relay
<basses:matrix.org> or
-
m-relay
-
m-relay
-
m-relay
<basses:matrix.org> I know this is not well-centered, but it should be centered if you prefer this design as it makes sense from mobile view.
-
m-relay
<basses:matrix.org> will there be any?
-
plowsof
.merge+ 2557 2564 2329 2558 2559 2565
-
xmr-pr
Added
-
m-relay
<diego:cypherstack.com> Maybe someday.
-
plowsof
.merges
-
xmr-pr
2557 2558 2559 2564 2565
-
plowsof
.merges
-
xmr-pr
2557 2558 2559 2564 2565
-
m-relay
<redsh4de:matrix.org> RTL i18n tweaks added:
-
m-relay
-
m-relay
<redsh4de:matrix.org> some slugs need to be translated but thats nothin
-
m-relay
<basses:matrix.org> great, but yu need to reverse the external link too
-
m-relay
-
m-relay
<redsh4de:matrix.org> sec
-
m-relay
<redsh4de:matrix.org> live now
-
m-relay
<basses:matrix.org> you forgot the footer
-
m-relay
<redsh4de:matrix.org> yup, refresh, added the parameter a min ago
-
m-relay
<basses:matrix.org> looks great
-
m-relay
<basses:matrix.org> also for download page
-
m-relay
<basses:matrix.org> learn more links
-
m-relay
-
m-relay
<basses:matrix.org> Desktop and Mobile strings are localizable?
-
m-relay
<redsh4de:matrix.org> missed it, adding
-
m-relay
<redsh4de:matrix.org> yes - just havent added the slugs on these yet
-
m-relay
<basses:matrix.org> ok, because they were not localized in any locale too.
-
m-relay
<redsh4de:matrix.org> have to replace the strings with the t() function
-
m-relay
<basses:matrix.org> found some issue
-
m-relay
<basses:matrix.org> if you open language menu and the burger menu on mobile the last opened menu doesn't close the previous one
-
m-relay
-
m-relay
<redsh4de:matrix.org> nice one, on it
-
m-relay
<redsh4de:matrix.org> pushed these
-
m-relay
<redsh4de:matrix.org> patched to make it look nicer, tricky to fully close it without javascript
-
m-relay
<basses:matrix.org>
privacyguides.org/en/basics/why-privacy-matters does it (mkdocs material)
-
m-relay
<basses:matrix.org> sucks how the icons disappear when js is disabled tho
-
m-relay
<basses:matrix.org> I think these are svgs thats why, anyways not relevant
-
m-relay
<basses:matrix.org> but it is fine rn, no need to change if complex
-
m-relay
<basses:matrix.org> accessbility: pressing "TAB" key from the top of the page.
-
m-relay
<basses:matrix.org> the dropdown nav doesn't work when it is selected and press "Enter" key
-
m-relay
<basses:matrix.org>
buffer.com can do it.
-
m-relay
<redsh4de:matrix.org> can make it work, but then the dropdown would not show up on hover - would have to click on it just like in buffer.com
-
m-relay
<redsh4de:matrix.org> was battling with that a few weeks ago, either i could do enter key expand - but no hover, or hover but no enter key expand
-
m-relay
<basses:matrix.org> hmmm. Will try to see what are the common implementation of dropdown menus, it is hover-based or click...
-
m-relay
<basses:matrix.org> basically what the user will most likely do with drop downmenus
-
m-relay
<basses:matrix.org> but the latter may win in favor of accessbility, hope people share their experience too
-
m-relay
<basses:matrix.org> yeah, all have it as hover, but they probably make use of js to make it also accessible
-
m-relay
<basses:matrix.org> what about we make it redirect to some index page on main dir? like when tabbing "Get started" it goes to
getmonero-redesign-impl.vercel.app/get-started with some index/cards of the topics that you would've seen with a hover?
-
m-relay
<basses:matrix.org> and that page will be accessbile by tabbing
-
m-relay
<basses:matrix.org> this will be only done for "get-started", "community" and "resources", right?
-
m-relay
<basses:matrix.org> if too complex then we can look into it later
-
m-relay
<redsh4de:matrix.org> not that complex, just would be a bit inconsistent
-
m-relay
<redsh4de:matrix.org> i'll note this down as something to look into
-
m-relay
<basses:matrix.org> cool, yeah anything can be subject to change if it might cause issues or unnecessary burden
-
m-relay
<basses:matrix.org> I think there will also be work necessary to improve seo in general (not some bs), and seo for i18n so it can come up in search results when people type about monero in their locale and search engine finds the right locale with content indexed
-
m-relay
<basses:matrix.org> btw, u didn't add a card for moneropedia in nav menu
-
m-relay
<basses:matrix.org> also looking forward when you make it localizable
-
m-relay
<redsh4de:matrix.org> on purpose - the moneropedia entry is meant to go under "knowledge base", no design for that available yet
-
m-relay
<redsh4de:matrix.org> the moneropedia page?
-
m-relay
<redsh4de:matrix.org> already is, just need to make translated .md files for the entries
-
m-relay
<redsh4de:matrix.org> i'll push one as an example
-
m-relay
<basses:matrix.org> can you do for Arabic?
-
m-relay
<redsh4de:matrix.org> added one
-
m-relay
<redsh4de:matrix.org> rates updated plowsof
-
plowsof
thanks redsh4de (unrelated: i cant fetch any git repo ree)
-
m-relay
<redsh4de:matrix.org> same, some kind of downtime
-
m-relay
<basses:matrix.org> great, it ignores diacritics and just adds the first letter of the word, right?
-
m-relay
<basses:matrix.org> the terms mentioned in an article from moneropedia will be translated too? because it isn't which I think it didn't have an entry in the localized word yet or you didn't wrap it in t()? also the tooltip when hovering over them is not localized
-
m-relay
<basses:matrix.org> plowsof, check
githubstatus.com/history
-
plowsof
Thanks
-
m-relay
-
m-relay
<basses:matrix.org> Resolved
-
m-relay
<redsh4de:matrix.org> no explicit handling for diacritics done, but thats how its supposed to work - categorized by first letter of word
-
m-relay
<redsh4de:matrix.org> the terms dont have to be wrapped in t, like in the old site they need a @ prefix, and a second .md file that includes that term in the frontmatter
-
m-relay
<redsh4de:matrix.org> for the same reason its not localized, because right now if a term is mentioned but a localized version is not available, it will fall back to the default locale
-
m-relay
<basses:matrix.org> wanted to check of the tooltip was respected RTL too
-
m-relay
<basses:matrix.org> wanted to check of the tooltip was respecting RTL too
-
m-relay
<basses:matrix.org> if*