-
br-m
<redsh4de:matrix.org> will use the mails icon from lucide > <@basses:matrix.org> there's also
svgrepo.com/vectors/newsletter and
svgrepo.com/vectors/news
-
plowsof
redsh4de > git rev-parse --path-format=absolute --show-toplevel --git-path hooks --git-path info --git-dir
-
plowsof
2026-Jan-19 16:57:18.840219
-
plowsof
10.25 │ fatal: not a git repository (or any of the parent directories): .git
-
plowsof
did some untested slop creep its way in somewhere
-
plowsof
:D
-
br-m
<redsh4de:matrix.org> this is likely due to my WSL crashing upon commit today
-
plowsof
can help/post logs proper soon,,, need charger
-
br-m
<redsh4de:matrix.org> corrupted some things, had to wipe everything
-
br-m
-
br-m
<redsh4de:matrix.org> deployed localization updates for blog tags & the external resource button layour improvements
-
br-m
<basses:matrix.org>
beta.monerodevs.org/downloads needs an info aside below cards saying something like "looking for mobile wallets or other community created wallets, visit /community (link)
-
br-m
-
br-m
<basses:matrix.org> placed here
-
br-m
<redsh4de:matrix.org> maybe above the cards so its more visible - similar pattern is already being used for the /hangouts and /workgroups pages
-
br-m
-
br-m
<redsh4de:matrix.org> i'll try both and see how it looks
-
plowsof
-
plowsof
ctrl+f fatal (to see the git line)
-
plowsof
undefined '$NIXPACKS_PATH' also , hm
-
plowsof
the deploy fails started with
redsh4de/monero-site e5680ee , @ lefthook install
-
br-m
<redsh4de:matrix.org> i see, it's the pre-commit hook installer
-
br-m
<redsh4de:matrix.org> it's trying to install hooks to the .git folder, but it is missing
-
plowsof
fix da hallucination
-
br-m
<redsh4de:matrix.org> not a hallucination, CI=true works with github actions for CI to skip trying to install as GA automatically sets it as per lefthook docs, but i guess it doesn't work here due to the variable not being set
-
br-m
<redsh4de:matrix.org> the shitty way to fix it is to add CI=true to the monerodevs deployment step
-
br-m
<redsh4de:matrix.org> good way is to figure out a more platform agnostic way to skip it
-
br-m
<redsh4de:matrix.org> @redsh4de:matrix.org: fwiw this is the recommended way:
lefthook.dev/usage/envs/CI.html
-
br-m
<ofrnxmr:xmr.mx> I dont know how husky works, never used or looked into it
-
br-m
<ofrnxmr:xmr.mx> But whats wrong with traditional pre-commits?
-
br-m
<ofrnxmr:xmr.mx> They dont / shouldnt run or install except for manually
-
br-m
<ofrnxmr:xmr.mx> example
basicswap/basicswap #333
-
br-m
<redsh4de:matrix.org> this might have changed, but iirc they are not version controlled
-
br-m
<ofrnxmr:xmr.mx> @ofrnxmr:xmr.mx: .pre-commit-config.yaml controls versions
-
br-m
<redsh4de:matrix.org> i see, you mean the pre-commit package, was talking about the traditional .git/hooks folder setup
-
br-m
<redsh4de:matrix.org> that was what i looked into first, but i didn't like the Python dependency
-
br-m
<redsh4de:matrix.org> Husky/Lefthook can be executed directly from the Node package manager without needing to use pip - makes sense to use a solution like that when the whole codebase already uses NPM
-
br-m
<ofrnxmr:xmr.mx> precommits are installed locally, and run when making commits
-
br-m
<ofrnxmr:xmr.mx> So it shouldnt even be installing for the deployment
-
br-m
<ofrnxmr:xmr.mx> Linters = run on github ci
-
br-m
<ofrnxmr:xmr.mx> pre-commit = run locally when making commits
-
br-m
<ofrnxmr:xmr.mx> neither should have any effect on build or deploy, no?
-
br-m
<redsh4de:matrix.org> Yes, that's why there was a CI env variable check which would skip the lefthook installation if it was true
-
br-m
<redsh4de:matrix.org> Issue is that the monerodevs CI does not set the env variable to true, and lefthook doc assumes that most CI's would
-
br-m
<redsh4de:matrix.org> I pushed a change that relies on the postinstall scripts instead of the prepare scripts with a filter. Not sure how they work under the hood, but maybe they have a smarter filtering
-
br-m
<ofrnxmr:xmr.mx> Im saying, none of these needs to be a part of the website
-
br-m
<ofrnxmr:xmr.mx> Shoukd be contained to .github/workflows and lint config files
-
br-m
<ofrnxmr:xmr.mx> running linters on ci should be exclusive ci job, not a build flag (?)
-
br-m
<redsh4de:matrix.org> Right, it is like that - it's not a part of the build step
-
br-m
<redsh4de:matrix.org> The issue here was that on package install to build the site, it was also trying to install the pre-commit package when it shouldn't
-
br-m
<redsh4de:matrix.org> @redsh4de:matrix.org: looks like the postinstall scripts are smarter, this works
-
br-m
<redsh4de:matrix.org> latest back up on
beta.monerodevs.org
-
plowsof
the PR causing the issue has a failing workflow @ CI / Build (push)
-
br-m
<redsh4de:matrix.org> That was due to a different issue - I hadn't set the CI=true check in the prepare script, i added it after noticing the failing workflow
-
br-m
<redsh4de:matrix.org> On CI, it installs only production packages via the --prod flag. lefthook is a developer depenency - not a package that is needed for production, so it was skipped. But the prepare script doesn't know that, so it tried to run the lefthook install command despite it not being installed, causing the error
-
br-m
<redsh4de:matrix.org>
mrelay.p2pool.observer/p/iPTdh94KNmhodzFh/1.txt (code snippet, 23 lines)
-
br-m
<redsh4de:matrix.org> Anything here is skipped/not needed when building
-
br-m
<redsh4de:matrix.org> added @basses:matrix.org, looks pretty good > <@redsh4de:matrix.org> i'll try both and see how it looks
-
br-m
-
br-m
<ofrnxmr> @redsh4de:matrix.org can you ELI5 me on how to install the pre-commit hooks for the repo?