-
xmr-pr
nahuhh opened pull request #2611: ci: add pr previews workflow
-
xmr-pr
-
br-m
<ofrnxmr:xmr.mx> @redsh4de:matrix.org i think the part of the workflow that creates a PR to update the core.json needs to be updated to work on beta branch
-
br-m
<ofrnxmr:xmr.mx> I messed with it last week and couldnt get it to open a pr on my own repo
-
br-m
<ofrnxmr:xmr.mx> All i tried was
-
br-m
<ofrnxmr:xmr.mx> - if: github.ref == format('refs/heads/{0}', github.event.repository.default_branch)
-
br-m
<ofrnxmr:xmr.mx> + if: github.ref == 'refs/heads/beta' || github.ref == format('refs/heads/{0}', github.event.repository.default_branch)
-
br-m
<ofrnxmr:xmr.mx> And would the monero-project repos are protected so i'm not sure that the workflow would even be able to create a branch for this cc plowsof
-
br-m
<ofrnxmr:xmr.mx> if so, maybe can be changed to comment a diff that needs to be applied
-
br-m
<redsh4de:matrix.org> yeah ill have to change it to target whichever branch hashes.txt was pushed to
-
br-m
<redsh4de:matrix.org> instead of the default one
-
br-m
<redsh4de:matrix.org> @ofrnxmr:xmr.mx: yeah if the workflow settings are read-only & workflows arent permitted to make PRs, the PR step won't work
-
br-m
<redsh4de:matrix.org> i had these enabled on the original repo
-
br-m
-
br-m
<ofrnxmr:xmr.mx> We had a problem with the pr_comment workflow on the docs repo, because the monero-project org had write perms disabled
-
br-m
<ofrnxmr:xmr.mx> So enabling per-repo didnt work
-
br-m
<ofrnxmr:xmr.mx> But i guess we can try
-
br-m
<ofrnxmr:xmr.mx> I set this on my own repo, but it didnt work > <@ofrnxmr:xmr.mx> All i tried was
-
br-m
-
br-m
<redsh4de:matrix.org> @ofrnxmr:xmr.mx: what about something like this?
redsh4de/monero-site 29b0e46
-
br-m
<redsh4de:matrix.org> should work on all branches regardless of default
-
br-m
<ofrnxmr> I think the main issue would still be the no-write permissions
-
br-m
<ofrnxmr> So this might work on our repos, but (likely) not on the monero-project one
-
br-m
<redsh4de:matrix.org> yeah thats the big one, this should just make the trigger antifragile
-
br-m
<ofrnxmr> probably a sane workaround would be to have actions bot comment on the pr with a diff to apply
-
br-m
<redsh4de:matrix.org> i guess we can try it out and see if it works - if it won't, can add some kind of fallback that just adds a comment yeah
-
br-m
<321bob321> Chmod 777
-
br-m
<ofrnxmr> @321bob321: We tried on docs and it was always respecting thr org settings
-
br-m
<321bob321> Time to move to forgejo