<thomasbuilds:matrix.org> that 2639 PR is important to merge and simple to review, in case anyone wants to review it

<ofrnxmr> @thomasbuilds:matrix.org: Why does it reformat so much? New plugin?

<thomasbuilds:matrix.org> No update to plugin I think

<thomasbuilds:matrix.org> prettier-plugin-astro is going v1

<ofrnxmr:xmr.mx> even if the site isnt launched, bulk reformatting of the repo screws up the blame

<ofrnxmr:xmr.mx> cant the prettier config be modifies to preserve the old formatting?

<thomasbuilds:matrix.org> That plugin should be updated to v1 imo. Could it be done in a separate PR? Probably. But I mean it's not that long to review as is...

<thomasbuilds:matrix.org> Also it would delay the important astro update v5 > 7 which currently holds big vulns

<ofrnxmr:xmr.mx> im not talking about udating to v1, just the prettier config

<ofrnxmr:xmr.mx> i would assume prettier's astro config can be given rules to not change the formatting

<ofrnxmr:xmr.mx> thats pretty intrusive for anyone who used it on any project til now

<ofrnxmr:xmr.mx> also not about review time, im specifically drawing a nit on the mass unrelated changes

<thomasbuilds:matrix.org> Yeah I get what u mean though I personally prefer the new stricter formatting lol

<thomasbuilds:matrix.org> Before HTML tags were inlined very ugly imo

<thomasbuilds:matrix.org> For instance <p class="summary"><span dir="ltr">{summary}</span></p>

<thomasbuilds:matrix.org> @ofrnxmr:xmr.mx: Having prettier installed as dep means we want to standardize coding style and before this PR it wasn't consistent

there is a disconnect we have to manage between production and a coolify instance running/building the site live

ideally the 'dependencies are pinned security++' marketing thing would allow production to build the site on a frozen / offline / for purpose machine that creates a zip file which is moved to machine that serves the raw html files

<thomasbuilds:matrix.org> I'd like to have a coding style on monero repo too, would make code much easier to read lol but too late now

contirbutors have to run the software on their machines shuld they wish to run things locally - do we know what cve's are being patched and are there any to for containerisation to protect devs?

s/any to for containerisation/any containerisation methods like docker

dockerised for current site monero-project/monero-site #2454

(CCS front end 'update to astro 7...8..9..10..11 with formatting including in each one for eternity sounds fun too lol)

<thomasbuilds:matrix.org> Lol I think the issue is just that prettier-plugin-astro didn't properly have code formatting configured and waited until v1 to fix this 'breaking' change

<thomasbuilds:matrix.org> Might be wrong im on a phone rn 💀

<thomasbuilds:matrix.org> But this code formatting issue won't happen again imo

<thomasbuilds:matrix.org> I dislike docker btw had many vulns involving stuff like root escalation privileges

<thomasbuilds:matrix.org> Your argument is that you consider npm to possibility provide malicious deps so you'd like to containerize the entire thing? > <plowsof> contirbutors have to run the software on their machines shuld they wish to run things locally - do we know what cve's are being patched and are there any to for containerisation to protect devs?

<ofrnxmr:xmr.mx> doesnt npm have supply chain vulns a few times this year

<ofrnxmr:xmr.mx> didnt*

<ofrnxmr:xmr.mx> i remember hitting some prettier linting issues before, so i assume it was working?

<redsh4de:matrix.org> fwiw the beta uses pnpm which has a stricter supply chain policy, iirc 14 days or something of the like as of v11

<thomasbuilds:matrix.org> @ofrnxmr:xmr.mx: Yeah it did but imo it doesn't matter here really because devs that want to contribute to the website do pnpm install and they install the same packages on lockfile. So those packages should be safe since otherwise it would have been known they hold malicious code. Those malicious packages get busted super quick

<redsh4de:matrix.org> it can be changed to preserve the legacy formatting, i can PR the new default formatting rules seperately after 2639 is merged > <@ofrnxmr:xmr.mx> i would assume prettier's astro config can be given rules to not change the formatting

so its just this which could be done in another PR? monero-project/monero-site #2639/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R56

<thomasbuilds:matrix.org> @redsh4de:matrix.org Am I right here? > <@thomasbuilds:matrix.org> Lol I think the issue is just that prettier-plugin-astro didn't properly have code formatting configured and waited until v1 to fix this 'breaking' change

<redsh4de:matrix.org> plowsof: the dep itself can be kept, can just tweak the config -> reformat which would keep the formatting as it is right now -> reduce the diff

<redsh4de:matrix.org> @thomasbuilds:matrix.org: thats the gist of it yeah, it wasn't fully complete

<thomasbuilds:matrix.org> Yeah so still needs to be fixed IMO for proper standardized coding style

<redsh4de:matrix.org> agree, but its a good point that the formatting changes blow up the diff a bit too much

<redsh4de:matrix.org> will make a seperate PR that depends on 2639

<ofrnxmr:xmr.mx> i would probably prefet the astro v7 update be split from the mass refactoring

make the PR to cuprate reformatting alot of code and see if its merged

<redsh4de:matrix.org> 🍎🍊

*looks at early beta site commits* nevermind

yes apples to oranges, its just git history of -site, who cares right? will CCS front end be treated better?

<redsh4de:matrix.org> anyway, updated the PR

<redsh4de:matrix.org> prettier-plugin-astro had to be downgraded back to the broken version for now

<redsh4de:matrix.org> will be updated in the follow up

<redsh4de:matrix.org> follow up in question, draft for now: monero-project/monero-site #2705

redsh4de opened pull request #2705: deps: bump prettier-plugin-astro to 1.0 [beta]

> monero-project/monero-site #2705