<s​needlewoods_xmr:matrix.org> Not sure if I can make it to the meeting, so here is my report in advance:

<s​needlewoods_xmr:matrix.org> Worked on `set_variable()` and replaced `i_wallet2_callback` with `WalletListener`, but need to test and make sure there is no regression.

<s​needlewoods_xmr:matrix.org> Currently `grep "\<m_wallet\>" src/simplewallet/simplewallet.cpp -c` gives 445 results

<r​brunner7:monero.social> Thanks for the report.

<r​brunner7:monero.social> Meeting in about 1 hour

<r​brunner7:monero.social> Meeting time. Hello! monero-project/meta #1214

<j​berman:monero.social> *waves*

<r​brunner7:monero.social> Alright, maybe fewer participants than usual. What is there to report from last week?

<r​brunner7:monero.social> For the record: SNeedlewoods reported earlier that they are still making their way through simplewallet, converting to the Wallet API

<r​brunner7:monero.social> I myself made my first PR since quite a long time: monero-project/monero #9939

<j​berman:monero.social> Opened this PR to fix tests and am working through some bugs for some failing tests atm: seraphis-migration/monero #50

<r​brunner7:monero.social> Do you have good coverage with the existing tests?

<r​brunner7:monero.social> I mean, not too many things really particular to FCMP++ and Carrot

What is (are? ) the benefit of changing simplewallet to use the wallet API ?

<j​berman:monero.social> I'd say yes, I'm working through functional tests at the moment

nvm, I'll ask later

<r​brunner7:monero.social> moneromooo: The "endgame" that we plan is moving everything away from wallet2.h to the Wallet API to get the freedom to re-implement the wallet

<j​berman:monero.social> Some more context seraphis-migration/wallet3 #64

So the wallet api will no longer be a layer above wallet2 then ?

<r​brunner7:monero.social> Thanks, I knew I wrote something deep in the past about that :)

<r​brunner7:monero.social> Ideally, yes.

Ah, yes, wallet3. Forgot aout this. Makes sense now.

<r​brunner7:monero.social> Maybe the wallet implementation itself, or a layer above ... something else, hopefully better structured

<r​brunner7:monero.social> So nice that the existing functional tests for transactions are still useful and have results, i.e. help you find bugs

<r​brunner7:monero.social> But I guess at some point some more specific tests for the new tech will be added?

<j​berman:monero.social> The integration brings a lot of major changes internally that these tests are hitting because they are wider in scope

<j​berman:monero.social> We've also been testing specific functionality as it's been added along the way (e.g. my tree code has extensive unit testing), with more planned too

<j​berman:monero.social> jeffro256: also has added hefty amount of Carrot specific unit tests too

<j​berman:monero.social> 8 new "carrot_" unit test files

<r​brunner7:monero.social> Sounds solid.

<r​brunner7:monero.social> I guess that's the way with really complex code.

<r​brunner7:monero.social> Alright, if you don't have something special to bring up, maybe we can already wrap up the meeting.

<r​brunner7:monero.social> Thanks for attending, read you again next week!

<j​berman:monero.social> @moneromooo do you recall off the top of your head any benefit outside of tests to supporting a way to create alt block templates via `create_block_template`?

<j​berman:monero.social> as in, block templates on top of an alternative chain

I... do not.

<j​berman:monero.social> (I ask because as the FMCP++ integration is currently implemented, the daemon would no longer be able to do that, and it's a huge lift to be able to do that)

I do not even remember why I added this.

<j​berman:monero.social> I don't think it was you, think it was there for tests from day 1

Oh, OK.

I do remember monkeying around with that though a few years back...

<r​brunner7:monero.social> Somehow sounds like a way to make 51% attacks a bit easier :)

<j​berman:monero.social> there was a new functional test for it that you added that I had to get rid of after implementing including FCMP++ merkle tree root in the block PoW hash

<d​angerousfreedom:matrix.org> Wow! A lot of things have been done in the past year! Thank you very much for the efforts rbrunner7 , jberman , jeffro256 and everyone! I will slowly try to update myself and the moneroinflation.com. jeffro256 , where should I start reading about CARROT?

<j​effro256:monero.social> Hi dangerousfreedom , it's great to see you again!

<j​effro256:monero.social> github.com/jeffro256/carrot/blob/master/carrot.md is a good starting point for Carrot

<j​berman:monero.social> welcome back!

welcome back dangerousfreedom