-
m-relay
<rbrunner7:monero.social> Meeting in a bit more than 1 hour
-
m-relay
<jberman:monero.social> In case I can't make today's meeting (looking unlikely), my update in advance: all expected tests now pass in fcmp++-stage (we have green CI), shared a TODO list for launch issue tracker (
seraphis-migration/monero #53), made serious headway on destroying FFI types correctly thanks to @jeffro256 (
seraphis-migration/monero #39).
-
m-relay
<jberman:monero.social> Working on finishing that last task, and allowing txs with >8 inputs next
-
m-relay
<rbrunner7:monero.social> Meeting time. Hello!
monero-project/meta #1218
-
m-relay
<sneedlewoods_xmr:matrix.org> hey
-
m-relay
<rbrunner7:monero.social> Probably no wave today from jberman , he left his report already about an hour ago
-
m-relay
<rbrunner7:monero.social> His TODO list for launch looks interesting:
seraphis-migration/monero #53
-
m-relay
<rbrunner7:monero.social> Do you have something to report?
-
m-relay
<sneedlewoods_xmr:matrix.org> I think I have found an overlap from that TODO list with my work on wallet-cli, there are two settings `default-ring-size` and `print-ring-members` that I would not add to the Wallet API
-
m-relay
<syntheticbird:monero.social> hi
-
m-relay
<sneedlewoods_xmr:matrix.org> unfortunately GUI and CLI settings differ, CLI settings are stored in the wallet file handled by wallet2 so I think they have to be part of the Wallet API
-
m-relay
<rbrunner7:monero.social> The GUI differs? You mean it offers a different set of settings, or stores them in a different way? The latter would be surprising
-
m-relay
<rbrunner7:monero.social> Maybe it does not offer all of them
-
m-relay
<rbrunner7:monero.social> `default-ring-size` is of course obsolete already for a long time and probably only presereved to avoid all risk something goes astray if a wallet has that set
-
m-relay
<sneedlewoods_xmr:matrix.org> sorry not well prepared, here is the set of settings for GUI
github.com/monero-project/monero-gu…9a48480aee2cc3/main.qml#L1378-L1480
-
m-relay
<rbrunner7:monero.social> *preserved
-
m-relay
<rbrunner7:monero.social> I think what you see there is a mix of GUI specific settings, app global i.e. not per wallet, and wallet specific settings that go into the wallet file like they do if you use the CLI wallet
-
m-relay
<sneedlewoods_xmr:matrix.org> but for example `allow_background_mining` or `restore_height` are also CLI settings
-
m-relay
<sneedlewoods_xmr:matrix.org> though IIRC that `restore_height` in GUI is only used for restore, else it relies on the `m_restore_height` or however it's called in wallet2
-
m-relay
<sneedlewoods_xmr:matrix.org> it's a bit tricky, but I think I'm on the right track
-
m-relay
<rbrunner7:monero.social> Anyway, I think both the CLI and the GUI code should be quite simple. It's also quite easy to see in the `wallet2` code itself what settings exactly are stored in the wallet files themselves. Will just take work and patience :)
-
m-relay
<rbrunner7:monero.social> That code is anyway the "ultimate source of truth" for per-wallet options
-
m-relay
<rbrunner7:monero.social> I have added an option or two myself there, in the good old times
-
m-relay
<rbrunner7:monero.social> Looks like the FCMP++ coding competition's end as set so far is less than 1 month away:
github.com/j-berman/fcmp-plus-plus-optimization-competition
-
m-relay
<rbrunner7:monero.social> I wonder whether somebody got confirmation already that at least *somebody* is working on something
-
m-relay
<rbrunner7:monero.social> jberman or jeffro256 , if you know something, please drop it later, just for curiosity's sake
-
m-relay
<syntheticbird:monero.social> sagewilder are you still participating to the tournament ?
-
m-relay
<rbrunner7:monero.social> Alright, anything else for today? With things running so smoothly at the moment, meetings are a piece of cake :)
-
m-relay
<rucknium:monero.social> Did you see selsta say next release will be tagged in two weeks? I wonder if subnet deduplication might be reviewed and approved before then.
-
m-relay
<rbrunner7:monero.social> Everything ready to merge to release branch in a mere two weeks looks unlikely IMHO
-
m-relay
<sneedlewoods_xmr:matrix.org> nothing from me
-
m-relay
<sneedlewoods_xmr:matrix.org> just thanks to jeffro and jberman for their hard work, got a ton of mails from the seraphis-migration repo recently lol
-
m-relay
<rbrunner7:monero.social> Right, the amount of PRs they do at the moment is amazing
-
m-relay
<rbrunner7:monero.social> It's a bit of a pity that it might miss the next release
-
m-relay
<rbrunner7:monero.social> Critical things often get some time of running them on master, just to be sure. And peer selection better works, right
-
m-relay
<sneedlewoods_xmr:matrix.org> I don't feel qualified for a review for the subnet PR
-
m-relay
<rbrunner7:monero.social> Yeah, it's a different corner of the codebase than on what you worked so far
-
m-relay
<rbrunner7:monero.social> Ok, I think we can close for today. Thanks everbody for attending, read you again next week, the week just before - hurray! - MoneroKon
-
m-relay
<sneedlewoods_xmr:matrix.org> thanks and cu
-
m-relay
<sagewilder:unredacted.org> No
-
m-relay
<rbrunner7:monero.social> Awww ...
-
m-relay
<sagewilder:unredacted.org> I underestimated the challenge of this competition and was sidetracked by another commitment.
-
m-relay