-
m-relay<jeffro256:monero.social> Yes, all coinbase must have an exact `unlock_time` set, which is their block index + 60. So if you removed that clause, the msg would trigger on each received coinbase tx.
-
m-relay<jeffro256:monero.social> I don't see why that notice should be removed , its very useful to people who receive locked funds and weren't expecting it
-
m-relay<jeffro256:monero.social> Yes
-
m-relay<sneedlewoods:monero.social> I'm not proposing to remove the notice. I was just wondering why we don't warn about coinbase txs. If there is no good reason, then I'd propose to expand the notice to also warn about locked coinbase txs.
-
m-relay<sneedlewoods:monero.social> Sorry if it's unclear what I'm talking about, to add a little more context. The cli uses `i_wallet2_callback` which has `cryptonote::transaction& tx` as argument for `on_money_received()`. For the callback in the Wallet API `moneyReceived()` we would need to add an argument `bool is_coinbase` or something.
-
moneromoooNo need, tx is already there, you can just look at whether it is a coinbase tx.
-
moneromoooYou could also make those txes stuck at 60 by consensus, I did this for TF.
10 hours ago