-
br-m
<rbrunner7> Meeting in 1 hour
-
br-m
<rbrunner7> Meeting time. Hello!
monero-project/meta #1427
-
br-m
<sneedlewoods_xmr:matrix.org> hey
-
selsta
hi
-
br-m
<rbrunner7> Holiday season meeting :)
-
br-m
<rbrunner7> Anyway, any reports from last week?
-
br-m
<rbrunner7> @jpk68:matrix.org left this yesterday: "My updates so far include testing the GUI for Qt6 migration, plus minor patches as usual, and pestering the i2pd developer to fix a few bugs/issues"
-
br-m
<sneedlewoods_xmr:matrix.org> mainly worked on your review comments on the wallet-rpc PR
-
br-m
<rbrunner7> I could fix a fat bug in the Polyseed PR thanks to selsta
-
br-m
<rbrunner7> And yes, that review
-
br-m
<rbrunner7> The Wallet RPC server is almost a new program now
-
selsta
rbrunner7: disclosure, the latest chatgpt model found it and i later validated it, that would have been a bad one if not caught
-
br-m
<rbrunner7> Oh. Interesting.
-
br-m
<rbrunner7> Sure, yeah. We wouldn't want to trash all existing multisig wallets
-
br-m
<rbrunner7> Beside this hit, where there many false alarms in that review?
-
selsta
honestly the models are quite good at not hallicuating at this point, it did not find any false alarms
-
br-m
<rbrunner7> If those models will be able to help with reviews, that will be a net win
-
br-m
<rbrunner7> I guess most people here are quite sceptical about incorporating code written by them, but reviews are a whole different story
-
selsta
definitely, as long as we don't become complacent in skipping human reviews, but it's useful as an extra layer
-
br-m
<jeffro256> Howdy
-
UkoeHB
hi, no updaes
-
UkoeHB
@jeffro256 what's the paper/section for
monero-project/monero #9828 ?
-
br-m
<jeffro256> Hi, working on some speedups and bug fixes recently:
monero-project/monero #10605 and
monero-project/monero #10924. Beefed up testing infra in preperation for the Carrot/FCMP++ test merges:
monero-project/monero #10934.
-
br-m
<ofrnxmr> @rbrunner7: Using them to sanity check your own review, or pre-review before submission is nice as well
-
br-m
<jeffro256> UkoeHB: It's mainly just an algebraic conversion that you can do if you know the equations for both curves
-
br-m
<rbrunner7> @jeffro256:monero.social: You think you can slip in somewhere a second review pass of my Polyseed PR? It ripened quite a bit since your initial review, there are also a few questions.
-
br-m
<jeffro256> But I can try to find a more official source
-
br-m
<jeffro256> @rbrunner7: That PR is on my TODO list. I think I should be able to give it another pass this week
-
br-m
<rbrunner7> Splendid!
-
br-m
<jeffro256> Thanks for the reminder
-
br-m
<rbrunner7> Seems we are through with the reports. Anything special to discuss or decide today?
-
br-m
<rbrunner7> Does not seem to be the case. So I think we can close already for today. Thanks for attending, read you again next week!
-
br-m
<jeffro256> UkoeHB: Do you want me to add it into the code as a comment?
-
UkoeHB
sure that would be helpful for future readers
-
br-m
<sneedlewoods_xmr:matrix.org> Thanks everyone
-
br-m
<jeffro256> How about linking RFC 7748?
-
br-m
-
UkoeHB
looks appropriate
-
br-m
<jberman> Apologies for missing. My udpate is continuing the same: upstream FCMP++ integration PR's and continuing down the rabbit hole to solve the sporadic double spends on stressnet
-
br-m
<rbrunner7> Thanks, added to the meeting log