-
br-m<sneedlewoods_xmr:matrix.org> this new method (github.com/monero-project/monero/bl…eba7bd/src/wallet/wallet2.cpp#L7372) FWIW was added as a more efficient alternative to calling balance() and unlocked_balance() for multiple accounts, and it's used by wallet-rpc, so if I don't want to regress this change in #1 [... too long, see mrelay.p2pool.observer/e/49Hl77cLNE1Tcjkx ]
-
br-m<sneedlewoods_xmr:matrix.org> 1. make Wallet API method less efficient by looping over std::vector<wallet2::account_balance> and create a new std::vector<std::pair<std::uint64_t, std::uint64_t>> to move into.
-
br-m<sneedlewoods_xmr:matrix.org> 2. remove wallet2::account_balance and make the wallet2::balances_per_account() return a vector of pairs.
-
br-m<sneedlewoods_xmr:matrix.org> I tend to prefer the ugly, but more efficient second option. But maybe someone has a better suggestion!?