-
br-m
<rbrunner7> Meeting in a bit more than 1 hour
-
br-m
<rbrunner7> Meeting time. Hello!
monero-project/meta #1475
-
br-m
<slowbeardigger:matrix.org> Hola
-
br-m
<sneedlewoods_xmr:matrix.org> Hey
-
tevador
Hi
-
br-m
<vtnerd> hi
-
br-m
<ofrnxmr> gm
-
br-m
<rbrunner7> Alright, let us start with the reports from last week
-
br-m
<sneedlewoods_xmr:matrix.org> mostly worked on wallet api fixes, also some smaller reviews
-
br-m
<rbrunner7> That's still somewhat in flux, i.e. not yet time for something like a final review?
-
br-m
<ap4sh:matrix.org> (hi)
-
br-m
<vtnerd> testing p2p ssl, a few things to iron out. also going to update my other prs/branches (including fcmp++ stuff) soon
-
br-m
<sneedlewoods_xmr:matrix.org> @rbrunner7: it was, but through the amount of new PRs were getting every week, every rebase brings up another round of AI reviews
-
br-m
<rbrunner7> Oh ...
-
br-m
<rbrunner7> Sisyphus comes to mind
-
br-m
<sneedlewoods_xmr:matrix.org> Yeah, kinda lol ... a lot of small changes came to simplewallet or wallet-rpc, when I'm done updating 9464, 10232, 10233 and 10819 accordingly, there are already so many new changes that it starts again. Though I feel the findings in general are getting more and more niche (or unrelated to my PRs and already pre-existing).
-
br-m
<jberman> sorry I'm late waves
-
br-m
<jberman> my update: upstream FCMP++ integration PR's are ready for review (all AI comments have been addressed), RFQ for integration audits as gone out
-
selsta
I worked on v0.18.5.4 to fix DNSSEC issue, trying to improve OpenBSD support and a couple other things
-
br-m
<slowbeardigger:matrix.org> Me: payment scanner for fcmp++ tested on stressnet, working well 🤣
-
br-m
<slowbeardigger:matrix.org> Will get the repo ready this week
-
br-m
<rbrunner7> @tevador: You made a PR that implements relative locks:
seraphis-migration/monero #507
-
br-m
<rbrunner7> Do I understand correctly? With this we get a full consensus implementation of a relative lock with 1 single possible duration, namely of 3 days?
-
br-m
<rbrunner7> So if people are comfortable with that, we will get relative locks with the next hardfork?
-
tevador
Yes. Can I request CI approval and review?
-
br-m
<rbrunner7> Nice.
-
tevador
The concept has been approved by MRL.
-
br-m
<jpk68:matrix.org> Hello, sorry for being late
-
br-m
<rbrunner7> Ah, ok, already a while back then?
-
tevador
The PR is only for the consensus changes, wallet code won't support it yet, but that's OK.
-
br-m
<ofrnxmr> me: havent worked on the nyx changes (bucketing, eviction etc) since mrl meeting. The 101s peer drop;rotation is an issue and the change for that is "hairy". Once fixed i'll probably ask ruck to run the sim using the series
-
br-m
<rbrunner7> Yes, understood, that's quite some other kind of work of course.
-
br-m
<jpk68:matrix.org> Me: worked on fixes for the docs and GUI, updated several PRs, did a few dozen reviews, worked on the generic signing device spec
-
br-m
<rbrunner7> Quite some number of balls up in the air at the same time :)
-
br-m
<rbrunner7> What did we do back then when we did not yet have emojis? Dark times indeed.
-
br-m
<jpk68:matrix.org> :P and :)
-
br-m
<slowbeardigger:matrix.org> 🏓🎱
-
br-m
<ofrnxmr> @rbrunner7: We said the quiet parts in our heads, or got in trouble for speaking them out loud
-
br-m
<rbrunner7> Ok :) Looks like that might be it as far as reports are concerned. Quite some things happening in parallel.
-
br-m
<rbrunner7> Do we have to discuss something else today?
-
br-m
<sneedlewoods_xmr:matrix.org> Saw this question from ofrnxmr, in case jberman and/or jeffro didn't see it and may want to consider it:
monero-project/monero #11408#discussion_r4312329153
-
br-m
<jpk68:matrix.org> Sorry, I somehow didn't see that comment from ofrn. My response is that I have no idea :)
-
selsta
I remember checking and pruning seed is not called that often, I'd say merge as is
-
br-m
<jberman> ya I wouldn't say that's worth fixing in FCMP code either
-
br-m
<rbrunner7> You mean it does not matter much whether it is optimized, or unaligned?
-
br-m
<rbrunner7> With 2 reads, I suppose?
-
br-m
<ofrnxmr> selsta: I mean, the specific suggestion by hyc to be added to the hard fork db migration
-
selsta
yes, it's not worth to add to the migration (the extra code required)
-
br-m
<jpk68:matrix.org> IIRC, this issue was reported by selsta (from H1 or something), and I verified it and opened the fix
-
br-m
<jberman> this is a relatively inconsequential section of code, not worth overloading migration code with this
-
br-m
<rbrunner7> I don't remember how those migrations work - do they work "in place" i.e. within the single blockchain file? Not needing huge amounts of free disk space?
-
br-m
<rbrunner7> (basically double the size of the blockchain file)
-
br-m
<rbrunner7> (Er, no, just about the size of the blockchain file again of course, if it's not in place)
-
br-m
<jberman> the FCMP++ migration currently has 2 components: 1) read 1 table of all the outputs in the db, and construct a new table of locked outputs (so it increases db size by something like 73 bytes per output in the chain), 2) construct the FCMP++ tree tables
-
br-m
<jberman> needs as much disk space as the chain is expected to take up, and not more
-
br-m
<rbrunner7> Ah, ok, the single blockchain file grows, but reasonably so. That is not too drastic then.
-
br-m
<rbrunner7> Alright, looks like we are through, and I can close the meeting. Thanks everybody for attending, read you again next week!
-
br-m
<sneedlewoods_xmr:matrix.org> Thanks everybody, cu