.merge+ 8186

Added

.merge+ 8154 8158 8159

Added

.merge+ 8187

Added

hyc: could you take a look again at monero-project/monero #8088 and approve if the PR is ok?

If anyone would be willing to review my PR monero-project/monero #8211, I would greatly appreciate it! I tried to simplify the changes that I made and I would be happy to help answer questions since it's a pretty big PR

(It's the final version for now)

how is one to use monerod `get_fee_estimate` to estimate a tx fee? one needs to know how big the tx is in bytes, but that requires generating the tx?

Yes.

how can a transaction be generated without a fee estimate in order to know the size in bytes?

Iteratively. Most of the time, you won't need to add a new output.

s/out/in/

See create_transactions_2

Or you can just select inputs that always sum >= wanted amount + 0.001 and you'll always be good.

is there any update on the status of next hard fork?

If you want to have your favorite IDE documented against Monero-dev's specifics, please vote here:

r4v3r23[m]: 1/2 multisig PRs were merged, a lot of the other big patches are also approved

but there is no date currently

there is an issue with version 0.17.3.1, when you add a contact to the address book, the bottom entry in the address book get reassigned the name of the new entry. what should I do about this, I am a developer and have been using monero for a while but have never tried to contribute?

<arimfexendrapus[> "there is an issue with version 0..." <- Of GUI?

yes

gui

* issue with Monero GUI version 0.17.3.1,

Open an issue on GitHub yet?

there is not a version 0.17.3.1 cli

no i have not

is that the preferred avenue?

For an issue

But

selsta: might be able to point you to the code

* the code if you're interested in investigating yourself

* the code if you're interested in investigating yourself

i would like to become familiar with the codebase, i feel like its only responsible

for me to have a deeper understanding of the back end

The code is likely in wallet2.cpp, a bit less likely to be in src/wallet/api

you could try using the address book in monero-wallet-cli, and see if a similar thing happens. If yes, the bug's almost certainly in wallet2.

okay, i will take a look there then i guess i should submit an issue on the github?

A PR if you can :) If you can't find it, an issue.

I added tests for address book functionality (tests/functional_tests). If they don't test that particular case, adding another test that "finds" this bug would be a nice plus if you're willing.

i mean, i don't know if im qualified to fix the problem, ill see if its something simple, but if not idk about that yet i havent even looked at the codebase before

Well, it's straight C++. No crypto involved, so you're likely to be just fine.

Good luck, and questions here about the code are welcome if you need clarity on some bits.

c++ is my jam 😝

thanks

this should be fun

maybe im being stupid but i cant find wallet2.cpp

find src -name wallet2.cpp

or, better: find . -name wallet2.cpp

im in a windows environment

shocker i know :P

Ouch, sorry :/ src/wallet

don't have that path

i downloaded the gui master

He's talking about the main Monero repo that inclures wallet-cli

Not gui

do i need just the main monero

okay gotcha sry took me a second to figure that on out

s/on/one/

😅

Oh right. A submodule in your case...

i just downloaded the master monero zip just so i dont run into any more issues like this

since you seem to me more familiar with that anyway

christ wallet2.cpp is 14k lines

Sounds like you found the right one :)

LOL

how many loc is Monero in total roundabout?

i see wallet2 is one of the largest files in the repo

<arimfexendrapus[m]> "how many loc is Monero in..." <- 265k lines of code

Here are some "actionable" stats if you're interested:

oh boy

there, the LOC is counted as code in .cpp files relative to code in header files.

yea

this is neat

(almost) obviously in order to incentivise the move the code from the headers into source files.

<selsta> "r4v3r23: 1/2 multisig PRs were..." <- are there any remaining issues? has the fee change been settled? IIRC that was what was holding up the fork

arimfexendrapus[m]: This one particularly confirms that the wallet2 is really heavy on the RAM as well. Think of RPi with only 2 GB of RAM, whose 3 of 4 cores cannot be used in such circumstances: cryptog.hopto.org/monero/health/dat…2deaaa/d562deaaa-mem-usage-prod.txt

ive never even thought about how much ram it uses on my personal box

* personal box tbh

* personal box tbh im not that concerned

those stats are only for the compiling anyway

i wouldnt try to compile something like this on a RPi

Laptops with 4 GB RAM are not unusual.

thats just asking for problems

true

But yeah. This is only developers' perspective. The user won't be affected at all.

thats a sad developer

using a 4gb laptop

So in other words: there are worse problems in the World :)

😝true that

seems to be tearing at the seams atm

the world i mean

When TSHTF, and I have to resort tapping my solar panels as the only energy source, than that 4 GB laptop will be the only way to work :)

arimfexendrapus[m]: It's gonna be alright. It just needs some ... clensing.

s/clensing/cleansing/

some of the solar stuff rn is nuts, i doubt that it would affect your usage of a regular destop or even workstation

which is pretty crazy to think about

i mean i wouldnt be mining anymore but for just regular usage...

I'm mounting 600 pW this week. So 300 W on average with 72 Ah storage.

see, not a problem

for a laptop anyway

arimfexendrapus[m]: Why not? Otherwise the energy goes to a waste. Selling it to the grid is out of option for me. I don't work for the government nor for the so called: Local Community.

i was just saying if i had to choose

arimfexendrapus[m]: Not at all. Even in rainy cloudy days, when you have to assume just 10% of the average output.

refridgerate my food -- mineing crypty

s/crypty/crypto/

* refrigerate my food -- mining crypto

lol

I store the bulk of my food in form of dry grains. Refrigerator is not sth. I'd count on, TBH.

OK. Sliding off topic, and I'm getting sleepy. GN.

hey technical question, i havent worked with cmake in VS only regular sln files, its saying that i need openssl

or something like that, ill figure it out on my own but if you know what to do off the top of your head...

There are copy-paste ready installation commands. I guess you're missing at least one of the deps.

im trying to actually work on the code not compile it

Still, CMake needs them to generate the Makefiles.

okay

and only on top of that, your VS can show you a valid project file.

*project tree.

Otherwise it crashes before this is possible.