-
ArtemVorotnikov[
I wonder if block id override for 202612 can be reduced to just correct block id comparison and override after all these years?
-
moneromoooo
Probably not. It'd just take an asshole to start serving this block and wedge any new user syncing off them.
-
ArtemVorotnikov[
<moneromoooo> "Probably not. It'd just take..." <- You mean every single node that serves this block during sync?
-
ArtemVorotnikov[
> <@moneromoooo:libera.chat> Probably not. It'd just take an asshole to start serving this block and wedge any new user syncing off them.
-
ArtemVorotnikov[
* All nodes serve it during sync just like any other block. It just has a historic anomaly in block id calculation.
-
moneromoooo
Were there not two blocks ? I barely remember what happened now.
-
moneromoooo
Oh, two txes. nvm.
-
ArtemVorotnikov[
* All nodes serve it during sync just like any other block. It just has a historic anomaly in block id calculation which could be implemented with a simple override:... (full message at <
libera.ems.host/_matrix/media/v3/do…2d3f6e2d6daf2b7d6b19794e5fc2222bb0f>)
-
moneromoooo
That looks a lot like what the current code does.
-
moneromoooo
Anyway, I see no need to change what works, but if you're reimplementing something, feel free to do it differently as long as correct.
-
ArtemVorotnikov[
yes, except current code serializes blob and keccaks it, I guess my proposal is just to hardcode it
-
ArtemVorotnikov[
* yes, except current code specifically for 202612 serializes blob and keccaks it, I guess my proposal is to just hardcode the override block id
-
sech1
to use override id, first you need to serialize and keccak the block you're overriding
-
ArtemVorotnikov[
sech1: why not just check against the 'supposed' block id?
-
sech1
Why would it matter
-
sech1
you're just changing the order of comparison
-
ArtemVorotnikov[
it's just making the code simpler fwiw
-
moneromoooo
I just looked at the code, I think the difference is you'd trigger on the exact block, instead of any possible block for that height ?
-
ArtemVorotnikov[
moneromoooo: 'correct' block id (if not for the override) is the commitment for that, no?
-
moneromoooo
I do not understand "commitment" in that context.
-
ArtemVorotnikov[
cryptographic commitment
-
moneromoooo
Well, I guess in the absence of a bug, the block hash commits to the content of the block, yes.
-
volkovyuri[m]
Hello! Gimme please email of the Core Team for some important questions... at site Getmonero.org I can't see full email and I see only "Email: dev[at]getmonero[dot]org"
-
volkovyuri[m]
Maybe email is dev⊙go ?
-
volkovyuri[m]
Help me please)
-
moneromoooo
Hmm. Quite a puzzle... Let me think...
-
moneromoooo
I think you may have the correct solution. It's not for support btw.
-
» binaryFate eagerly waiting for important questions
-
moneromoooo
What is... your fate ?
-
moneromoooo
Helps to picture that scene from the Holy Grail on the bridge.
-
binaryFate
... blue!