UkoeHBcan you confirm how cold-signing will work in seraphis? i remember you said somewhere key images won't need to be imported/exported, but will outputs/enotes still need to be? or will it be simplified down to just unsigned tx/signed tx?

r4v3r23[m]: yes just unsigned tx / signed tx

thanks

Where do I start my search for the problem if a release build is successful but a debug build fails, while linking as it seems, with some missing symbol

I try to compile UkoeHB's latest seraphis_lib branch, "make" goes through, "make debug" gives me this error: paste.debian.net/1285853

Check the lib with work_while_waiting is linked in after scan_ledger_chunk_async.cpp.

If you're unlucky, there's a circular dep.

What is "work_while_waiting"?

I can only guess. I did not work with that code.

Ah, you reference a symbol in that code. I was taking it as the name of some analysis tool, linker option, or whatever :)

Yes, it's the one the error complains about.

Alright, thanks.

rbrunner: nuke you build directory and try again, might fix it

this line is quite suspicious src/wallet/CMakeFiles/wallet_rpc_server.dir/wallet_rpc_server.cpp.o

Well, that's more or less random, I compiled with 4 threads, and that's just what was compiled in one of them before another one had the error

But good idea anyway, C++ dev's equivalent of "Have you already tried switching it off and on again" :)

ah righ

Would this regex be correct for a standard monero address? /(?:^[48][0-9AB][1-9A-HJ-NP-Za-km-z]{93}$)/

* Would this regex be correct for a standard monero address? /(?:^\[48\]\[0-9AB\]\[1-9A-HJ-NP-Za-km-z\]{93}$)/

* Would this regex be correct for a standard monero address?

`/(?:^\[48\]\[0-9AB\]\[1-9A-HJ-NP-Za-km-z\]{93}$)/`

I found a few online but some didn't work with subaddresses, so I changed them around a bit

recanman[m]: > <@recanman:agoradesk.com> Would this regex be correct for a standard monero address?

> `/(?:^\[48\]\[0-9AB\]\[1-9A-HJ-NP-Za-km-z\]{93}$)/`

I don't mean to match integrated addresses

Is the only monero javascript library this onehttps://github.com/monero-ecosystem/monero-javascript?

s/onehttps/one https/

Test it on regex101.com

I checked a few addresses and it matched them

Thank you, I just wanted to make sure I didn't miss any edge cases

[0-9AB] can be changed to [1-9AB]

because base58 doesn't have '0'

Thank you

rbrunner: it is also failing for me, I must have broken something

jeffro256[m]: of course not.

I'm wondering if this is a valid assertion added to the release-v0.18 branch to check if outputs are frozen before using them: github.com/monero-project/monero/bl…50be6d/src/wallet/wallet2.cpp#L2008

for example, can key images be imported to the multisig participants in different orders and times, so the key image ordering could be different?

asking because this wasn't asserted in the code prior, and my multisig wallets were working

whereas now I hit that exception on signing the multisig tx

I recall double checking in the scan_tx PR that multisig does rely on consistently ordered key image imports

need to re-check, not sure why you didn't run into issues prior to that change

I don't think you can rely on ordering, an oversight in that PR?

^that makes more sense. Nevermind what I said. I had checked that multisig relies on consistent ordering of m_transfers which key image imports shouldn't affect

rbrunner: ok should be fixed

m_transfers should be ordered in (canonical) blockchain order.

UkoeHB: Thanks, will have a look probably on Sunday.